pr feedback

Author: transphorm

packages/mobile-sdk-alpha/src/browser.ts

@@ -40,8 +40,13 @@ export type { SdkErrorCategory } from './errors';
 
 export { SCANNER_ERROR_CODES, notImplemented, sdkError } from './errors';
 export { SelfClientContext, SelfClientProvider, useSelfClient } from './context';
+// Browser-only high-level component (DOM-based)
+export { SelfMobileSdk as SelfMobileSdkHighLevel } from './components/SelfMobileSdk';
+
 export { createSelfClient } from './client';
+
 export { defaultConfig } from './config/defaults';
+
 export { extractMRZInfo, formatDateToYYMMDD, scanMRZ } from './mrz';
 
 // Core functions

packages/mobile-sdk-alpha/src/context.tsx

@@ -1,4 +1,4 @@
-import { createContext, type PropsWithChildren, useContext, useEffect, useState } from 'react';
+import { createContext, type PropsWithChildren, useContext, useMemo } from 'react';
 
 import { createSelfClient } from './client';
 import type { Adapters, Config, SelfClient } from './types/public';
@@ -13,18 +13,7 @@ export interface SelfClientProviderProps {
 export { SelfClientContext };
 
 export function SelfClientProvider({ config, adapters = {}, children }: PropsWithChildren<SelfClientProviderProps>) {
-  const [client, setClient] = useState<SelfClient | null>(null);
-  const [isLoading, setIsLoading] = useState(true);
-
-  useEffect(() => {
-    const clientInstance = createSelfClient({ config, adapters });
-    setClient(clientInstance);
-    setIsLoading(false);
-  }, [config, adapters]);
-
-  if (isLoading) {
-    return <div>Loading...</div>; // Simple loading state, can be customized
-  }
+  const client = useMemo(() => createSelfClient({ config, adapters }), [config, adapters]);
 
   return <SelfClientContext.Provider value={client}>{children}</SelfClientContext.Provider>;
 }

packages/mobile-sdk-alpha/src/hooks/useDocumentManager.ts

@@ -1,4 +1,4 @@
-import { useCallback, useLayoutEffect, useState } from 'react';
+import { useCallback, useEffect, useState } from 'react';
 
 import type { DocumentData, ExternalAdapter } from '../types/ui';
 
@@ -8,7 +8,7 @@ export const useDocumentManager = (external: ExternalAdapter) => {
   }>({});
   const [isLoading, setIsLoading] = useState(true);
 
-  useLayoutEffect(() => {
+  useEffect(() => {
     external
       .getAllDocuments()
       .then(documents => {

packages/mobile-sdk-alpha/src/index.ts

@@ -72,12 +72,13 @@ export { SelfClientContext, SelfClientProvider, useSelfClient } from './context'
 // Components
 export { SelfMobileSdk } from './entry';
 
-export { SelfMobileSdk as SelfMobileSdkHighLevel } from './components/SelfMobileSdk';
-
 export { createSelfClient } from './client';
 
 export { defaultConfig } from './config/defaults';
 
+/** @deprecated Use createSelfClient().extractMRZInfo or import from './mrz' */
+export { extractMRZInfo } from './mrz';
+
 export { formatDateToYYMMDD, scanMRZ } from './mrz';
 
 // Core functions

packages/mobile-sdk-alpha/tests/SelfMobileSdk.test.tsx

@@ -2,13 +2,13 @@ import { describe, expect, it } from 'vitest';
 
 describe('High-Level SelfMobileSdk Component', () => {
   it('can be imported successfully', async () => {
-    const { SelfMobileSdk } = await import('../src/components/SelfMobileSdk');
+    const { SelfMobileSdk } = await import('../src');
     expect(SelfMobileSdk).toBeDefined();
     expect(typeof SelfMobileSdk).toBe('function');
   });
 
   it('accepts the expected props interface', async () => {
-    const { SelfMobileSdk } = await import('../src/components/SelfMobileSdk');
+    const { SelfMobileSdk } = await import('../src');
 
     // Test that the component accepts the expected props structure
     const mockExternal = {

packages/mobile-sdk-alpha/tests/client.test.ts

@@ -1,6 +1,6 @@
 import { describe, expect, it, vi } from 'vitest';
 
-import type { CryptoAdapter, NetworkAdapter, ScannerAdapter } from '../src/adapters/index';
+import type { CryptoAdapter, NetworkAdapter, ScannerAdapter } from '../src';
 import { createSelfClient } from '../src/index';
 
 describe('createSelfClient', () => {

packages/mobile-sdk-alpha/tests/client.test.tsx

@@ -1,7 +1,8 @@
 import { describe, expect, it } from 'vitest';
 
 import { createSelfClient } from '../src/index';
-import { expectedMRZResult, mockAdapters, sampleMRZ } from './utils/testHelpers';
+import { MrzParseError } from '../src/processing/mrz';
+import { badCheckDigitsMRZ, expectedMRZResult, invalidMRZ, mockAdapters, sampleMRZ } from './utils/testHelpers';
 
 describe('createSelfClient API', () => {
   it('creates a client instance with expected methods', () => {
@@ -29,4 +30,15 @@ describe('createSelfClient API', () => {
     expect(clientWithAllAdapters).toBeDefined();
     expect(typeof clientWithAllAdapters.extractMRZInfo).toBe('function');
   });
+
+  it('throws MrzParseError for malformed MRZ input', () => {
+    const client = createSelfClient({ config: {}, adapters: mockAdapters });
+    expect(() => client.extractMRZInfo(invalidMRZ)).toThrowError(MrzParseError);
+  });
+
+  it('flags invalid check digits', () => {
+    const client = createSelfClient({ config: {}, adapters: mockAdapters });
+    const info = client.extractMRZInfo(badCheckDigitsMRZ);
+    expect(info.validation.overall).toBe(false);
+  });
 });

packages/mobile-sdk-alpha/tests/utils/testHelpers.ts

@@ -3,14 +3,27 @@ import type { CryptoAdapter, NetworkAdapter, ScannerAdapter } from '../../src';
 
 // Shared test data
 export const sampleMRZ = `P<UTOERIKSSON<<ANNA<MARIA<<<<<<<<<<<<<<<<<<<\nL898902C36UTO7408122F1204159ZE184226B<<<<<10`;
+// Intentionally malformed MRZ (invalid structure/check digits) for negative tests
+export const invalidMRZ = 'NOT_A_VALID_MRZ';
+export const badCheckDigitsMRZ = sampleMRZ.slice(0, -1) + '1';
 
 // Shared mock adapters
 export const mockScanner: ScannerAdapter = {
   scan: async () => ({ mode: 'mrz', passportNumber: '', dateOfBirth: '', dateOfExpiry: '' }),
 };
 
 export const mockNetwork: NetworkAdapter = {
-  http: { fetch: async () => ({ ok: true }) as any },
+  // Return a minimal stub to avoid relying on global Response in JSDOM/Node
+  http: {
+    fetch: async () =>
+      ({
+        ok: true,
+        status: 200,
+        text: async () => '',
+        json: async () => ({}),
+        arrayBuffer: async () => new ArrayBuffer(0),
+      }) as any,
+  },
   ws: {
     connect: () => ({
       send: () => {},