more cr feedback

Author: transphorm

app/package.json

@@ -170,8 +170,9 @@
     "@testing-library/react-native": "^13.3.3",
     "@tsconfig/react-native": "^3.0.6",
     "@types/add": "^2",
+    "@types/bn.js": "^5.2.0",
     "@types/dompurify": "^3.2.0",
-    "@types/elliptic": "^6",
+    "@types/elliptic": "^6.4.18",
     "@types/jest": "^29.5.14",
     "@types/node": "^22.18.3",
     "@types/node-forge": "^1.3.14",

app/scripts/alias-imports.cjs

@@ -65,6 +65,16 @@ function transformProjectToAliasImports(project, appRootPath) {
         declaration.setModuleSpecifier(newSpec);
       } catch (error) {
         // Skip declarations that can't be processed (e.g., type-only imports with issues)
+        const msg = error instanceof Error ? error.message : String(error);
+        console.warn(
+          `Skipping import declaration in ${sourceFile.getFilePath()}: ${msg}`,
+        );
+        try {
+          console.debug('Import declaration text:', declaration.getText());
+        } catch {}
+        if (error && typeof error === 'object' && 'stack' in error) {
+          console.debug('Error stack:', error.stack);
+        }
         continue;
       }
     }
@@ -116,6 +126,16 @@ function transformProjectToAliasImports(project, appRootPath) {
         declaration.setModuleSpecifier(newSpec);
       } catch (error) {
         // Skip declarations that can't be processed
+        const msg = error instanceof Error ? error.message : String(error);
+        console.warn(
+          `Skipping export declaration in ${sourceFile.getFilePath()}: ${msg}`,
+        );
+        try {
+          console.debug('Export declaration text:', declaration.getText());
+        } catch {}
+        if (error && typeof error === 'object' && 'stack' in error) {
+          console.debug('Error stack:', error.stack);
+        }
         continue;
       }
     }

app/src/navigation/index.tsx

@@ -56,7 +56,7 @@ export type RootStackParamList = Omit<
   'ComingSoon' | 'IDPicker' | 'AadhaarUpload' | 'AadhaarUploadError'
 > & {
   ComingSoon: {
-    countryCode: string;
+    countryCode?: string;
     documentCategory?: string;
   };
   IDPicker: {

app/src/providers/selfClientProvider.tsx

@@ -163,13 +163,10 @@ export const SelfClientProvider = ({ children }: PropsWithChildren) => {
         countryCode: string | null;
         documentCategory: string | null;
       }) => {
-        // Only navigate if we have a valid country code
-        if (countryCode) {
-          navigateIfReady('ComingSoon', {
-            countryCode,
-            documentCategory: documentCategory ?? undefined,
-          });
-        }
+        navigateIfReady('ComingSoon', {
+          countryCode: countryCode ?? undefined,
+          documentCategory: documentCategory ?? undefined,
+        });
       },
     );
 

app/src/types/elliptic.d.ts

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: BUSL-1.1
 // NOTE: Converts to Apache-2.0 on 2029-06-11 per LICENSE.
 
-import type { create } from 'zustand';
+import { create } from 'zustand';
 
 import type { DocumentCatalog, IDDocument, PassportData } from '@selfxyz/common';
 

packages/mobile-sdk-alpha/src/types/public.ts

@@ -7346,8 +7346,9 @@ __metadata:
     "@testing-library/react-native": "npm:^13.3.3"
     "@tsconfig/react-native": "npm:^3.0.6"
     "@types/add": "npm:^2"
+    "@types/bn.js": "npm:^5.2.0"
     "@types/dompurify": "npm:^3.2.0"
-    "@types/elliptic": "npm:^6"
+    "@types/elliptic": "npm:^6.4.18"
     "@types/jest": "npm:^29.5.14"
     "@types/node": "npm:^22.18.3"
     "@types/node-forge": "npm:^1.3.14"
@@ -11512,7 +11513,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@types/bn.js@npm:*, @types/bn.js@npm:^5.1.0":
+"@types/bn.js@npm:*, @types/bn.js@npm:^5.1.0, @types/bn.js@npm:^5.2.0":
   version: 5.2.0
   resolution: "@types/bn.js@npm:5.2.0"
   dependencies:
@@ -11635,7 +11636,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@types/elliptic@npm:^6":
+"@types/elliptic@npm:^6.4.18":
   version: 6.4.18
   resolution: "@types/elliptic@npm:6.4.18"
   dependencies: