Add thorough test cases for mobile app (#752)

* Add actor mock helper and tests

* format tests

* fix tests

* Revert non-app tests

* update tests

* fix tests

* coderabbit feedback

* revert change

* remove spurious tests

Author: transphorm

app/src/utils/deeplinks.ts

@@ -16,12 +16,14 @@ const decodeUrl = (encodedUrl: string): string => {
   try {
     return decodeURIComponent(encodedUrl);
   } catch (error) {
-    console.error('Error decoding URL:', error);
+    if (typeof __DEV__ !== 'undefined' && __DEV__) {
+      console.error('Error decoding URL:', error);
+    }
     return encodedUrl;
   }
 };
 
-const handleUrl = (uri: string) => {
+export const handleUrl = (uri: string) => {
   const decodedUri = decodeUrl(uri);
   const encodedData = queryString.parseUrl(decodedUri).query;
   const sessionId = encodedData.sessionId;
@@ -37,7 +39,9 @@ const handleUrl = (uri: string) => {
 
       return;
     } catch (error) {
-      console.error('Error parsing selfApp:', error);
+      if (typeof __DEV__ !== 'undefined' && __DEV__) {
+        console.error('Error parsing selfApp:', error);
+      }
       navigationRef.navigate('QRCodeTrouble');
     }
   } else if (sessionId && typeof sessionId === 'string') {
@@ -66,11 +70,15 @@ const handleUrl = (uri: string) => {
 
       navigationRef.navigate('MockDataDeepLink');
     } catch (error) {
-      console.error('Error parsing mock_passport data or navigating:', error);
+      if (typeof __DEV__ !== 'undefined' && __DEV__) {
+        console.error('Error parsing mock_passport data or navigating:', error);
+      }
       navigationRef.navigate('QRCodeTrouble');
     }
   } else {
-    console.error('No sessionId or selfApp found in the data');
+    if (typeof __DEV__ !== 'undefined' && __DEV__) {
+      console.error('No sessionId or selfApp found in the data');
+    }
     navigationRef.navigate('QRCodeTrouble');
   }
 };

app/src/utils/notifications/notificationService.ts

@@ -6,6 +6,15 @@ import { PermissionsAndroid, Platform } from 'react-native';
 const API_URL = 'https://notification.self.xyz';
 const API_URL_STAGING = 'https://notification.staging.self.xyz';
 
+// Determine if running in test environment
+const isTestEnv = process.env.NODE_ENV === 'test';
+const log = (...args: any[]) => {
+  if (!isTestEnv) console.log(...args);
+};
+const error = (...args: any[]) => {
+  if (!isTestEnv) console.error(...args);
+};
+
 export const getStateMessage = (state: string): string => {
   switch (state) {
     case 'idle':
@@ -47,7 +56,7 @@ export async function requestNotificationPermission(): Promise<boolean> {
           PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS,
         );
         if (permission !== PermissionsAndroid.RESULTS.GRANTED) {
-          console.log('Notification permission denied');
+          log('Notification permission denied');
           return false;
         }
       }
@@ -58,11 +67,11 @@ export async function requestNotificationPermission(): Promise<boolean> {
       authStatus === messaging.AuthorizationStatus.AUTHORIZED ||
       authStatus === messaging.AuthorizationStatus.PROVISIONAL;
 
-    console.log('Notification permission status:', enabled);
+    log('Notification permission status:', enabled);
 
     return enabled;
-  } catch (error) {
-    console.error('Failed to request notification permission:', error);
+  } catch (err) {
+    error('Failed to request notification permission:', err);
     return false;
   }
 }
@@ -71,12 +80,12 @@ export async function getFCMToken(): Promise<string | null> {
   try {
     const token = await messaging().getToken();
     if (token) {
-      console.log('FCM Token received');
+      log('FCM Token received');
       return token;
     }
     return null;
-  } catch (error) {
-    console.error('Failed to get FCM token:', error);
+  } catch (err) {
+    error('Failed to get FCM token:', err);
     return null;
   }
 }
@@ -91,7 +100,7 @@ export async function registerDeviceToken(
     if (!token) {
       token = await messaging().getToken();
       if (!token) {
-        console.log('No FCM token available');
+        log('No FCM token available');
         return;
       }
     }
@@ -106,7 +115,7 @@ export async function registerDeviceToken(
     };
 
     if (cleanedToken.length > 10) {
-      console.log(
+      log(
         'Registering device token:',
         `${cleanedToken.substring(0, 5)}...${cleanedToken.substring(
           cleanedToken.length - 5,
@@ -125,19 +134,12 @@ export async function registerDeviceToken(
 
     if (!response.ok) {
       const errorText = await response.text();
-      console.error(
-        'Failed to register device token:',
-        response.status,
-        errorText,
-      );
+      error('Failed to register device token:', response.status, errorText);
     } else {
-      console.log(
-        'Device token registered successfully with session_id:',
-        sessionId,
-      );
+      log('Device token registered successfully with session_id:', sessionId);
     }
-  } catch (error) {
-    console.error('Error registering device token:', error);
+  } catch (err) {
+    error('Error registering device token:', err);
   }
 }
 
@@ -154,13 +156,13 @@ export interface RemoteMessage {
 export function setupNotifications(): () => void {
   messaging().setBackgroundMessageHandler(
     async (remoteMessage: RemoteMessage) => {
-      console.log('Message handled in the background!', remoteMessage);
+      log('Message handled in the background!', remoteMessage);
     },
   );
 
   const unsubscribeForeground = messaging().onMessage(
     async (remoteMessage: RemoteMessage) => {
-      console.log('Foreground message received:', remoteMessage);
+      log('Foreground message received:', remoteMessage);
     },
   );
 

app/tests/src/hooks/useAppUpdates.test.ts

@@ -0,0 +1,70 @@
+// SPDX-License-Identifier: BUSL-1.1; Copyright (c) 2025 Social Connect Labs, Inc.; Licensed under BUSL-1.1 (see LICENSE); Apache-2.0 from 2029-06-11
+
+import { useNavigation } from '@react-navigation/native';
+import { act, renderHook, waitFor } from '@testing-library/react-native';
+
+jest.mock('@react-navigation/native', () => ({
+  useNavigation: jest.fn(),
+}));
+
+jest.mock('react-native-check-version', () => ({
+  checkVersion: jest.fn(),
+}));
+
+jest.mock('../../../src/utils/modalCallbackRegistry', () => ({
+  registerModalCallbacks: jest.fn().mockReturnValue(1),
+}));
+
+jest.mock('../../../src/utils/analytics', () => () => ({
+  trackEvent: jest.fn(),
+}));
+
+import { checkVersion } from 'react-native-check-version';
+
+import { useAppUpdates } from '../../../src/hooks/useAppUpdates';
+import { registerModalCallbacks } from '../../../src/utils/modalCallbackRegistry';
+
+const navigate = jest.fn();
+(useNavigation as jest.Mock).mockReturnValue({ navigate });
+
+describe('useAppUpdates', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('indicates update available', async () => {
+    (checkVersion as jest.Mock).mockResolvedValue({
+      needsUpdate: true,
+      url: 'u',
+    });
+
+    const { result } = renderHook(() => useAppUpdates());
+
+    // Wait for the async state update to complete
+    await waitFor(() => {
+      expect(result.current[0]).toBe(true);
+    });
+  });
+
+  it('shows modal when triggered', async () => {
+    (checkVersion as jest.Mock).mockResolvedValue({
+      needsUpdate: true,
+      url: 'u',
+    });
+
+    const { result } = renderHook(() => useAppUpdates());
+
+    // Wait for the async checkVersion to complete first
+    await waitFor(() => {
+      expect(result.current[0]).toBe(true);
+    });
+
+    // Now test the modal trigger
+    act(() => {
+      result.current[1]();
+    });
+
+    expect(registerModalCallbacks).toHaveBeenCalled();
+    expect(navigate).toHaveBeenCalledWith('Modal', expect.any(Object));
+  });
+});

app/tests/src/hooks/useConnectionModal.test.ts

@@ -0,0 +1,85 @@
+// SPDX-License-Identifier: BUSL-1.1; Copyright (c) 2025 Social Connect Labs, Inc.; Licensed under BUSL-1.1 (see LICENSE); Apache-2.0 from 2029-06-11
+
+import { act, renderHook } from '@testing-library/react-native';
+
+jest.useFakeTimers();
+
+jest.mock('../../../src/navigation', () => ({
+  navigationRef: { isReady: jest.fn(() => true), navigate: jest.fn() },
+}));
+
+jest.mock('../../../src/hooks/useModal');
+jest.mock('@react-native-community/netinfo', () => ({
+  useNetInfo: jest
+    .fn()
+    .mockReturnValue({ isConnected: false, isInternetReachable: false }),
+}));
+
+import useConnectionModal from '../../../src/hooks/useConnectionModal';
+import { useModal } from '../../../src/hooks/useModal';
+
+const showModal = jest.fn();
+const dismissModal = jest.fn();
+(useModal as jest.Mock).mockReturnValue({
+  showModal,
+  dismissModal,
+  visible: false,
+});
+
+describe('useConnectionModal', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('shows modal when no connection', () => {
+    const { result } = renderHook(() => useConnectionModal());
+    act(() => {
+      jest.advanceTimersByTime(2000);
+    });
+    expect(showModal).toHaveBeenCalled();
+    expect(result.current.visible).toBe(false);
+  });
+
+  it('dismisses modal when connection is restored', () => {
+    (useModal as jest.Mock).mockReturnValue({
+      showModal,
+      dismissModal,
+      visible: true,
+    });
+
+    const { useNetInfo } = require('@react-native-community/netinfo');
+    useNetInfo.mockReturnValue({
+      isConnected: true,
+      isInternetReachable: true,
+    });
+
+    renderHook(() => useConnectionModal());
+    act(() => {
+      jest.advanceTimersByTime(2000);
+    });
+    expect(dismissModal).toHaveBeenCalled();
+  });
+
+  it('does not show modal when hideNetworkModal is true', () => {
+    jest.doMock('../../../src/stores/settingStore', () => ({
+      useSettingStore: jest.fn(() => true),
+    }));
+
+    renderHook(() => useConnectionModal());
+    act(() => {
+      jest.advanceTimersByTime(2000);
+    });
+    expect(showModal).not.toHaveBeenCalled();
+  });
+
+  it('does not show modal when navigation is not ready', () => {
+    const { navigationRef } = require('../../../src/navigation');
+    navigationRef.isReady.mockReturnValue(false);
+
+    renderHook(() => useConnectionModal());
+    act(() => {
+      jest.advanceTimersByTime(2000);
+    });
+    expect(showModal).not.toHaveBeenCalled();
+  });
+});

app/tests/src/hooks/useHapticNavigation.test.ts

@@ -0,0 +1,59 @@
+// SPDX-License-Identifier: BUSL-1.1; Copyright (c) 2025 Social Connect Labs, Inc.; Licensed under BUSL-1.1 (see LICENSE); Apache-2.0 from 2029-06-11
+
+import { useNavigation } from '@react-navigation/native';
+import { act, renderHook } from '@testing-library/react-native';
+
+import {
+  impactLight,
+  impactMedium,
+  selectionChange,
+} from '../../../src/utils/haptic';
+
+jest.mock('@react-navigation/native', () => ({
+  useNavigation: jest.fn(),
+}));
+
+jest.mock('../../../src/utils/haptic', () => ({
+  impactLight: jest.fn(),
+  impactMedium: jest.fn(),
+  selectionChange: jest.fn(),
+}));
+
+const navigate = jest.fn();
+const popTo = jest.fn();
+(useNavigation as jest.Mock).mockReturnValue({ navigate, popTo });
+
+import useHapticNavigation from '../../../src/hooks/useHapticNavigation';
+
+describe('useHapticNavigation', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('navigates with light impact by default', () => {
+    const { result } = renderHook(() => useHapticNavigation('Home'));
+    act(() => {
+      result.current();
+    });
+    expect(impactLight).toHaveBeenCalled();
+    expect(navigate).toHaveBeenCalledWith('Home');
+  });
+
+  it('uses cancel action', () => {
+    const { result } = renderHook(() =>
+      useHapticNavigation('Home', { action: 'cancel' }),
+    );
+    act(() => result.current());
+    expect(selectionChange).toHaveBeenCalled();
+    expect(popTo).toHaveBeenCalledWith('Home');
+  });
+
+  it('uses confirm action', () => {
+    const { result } = renderHook(() =>
+      useHapticNavigation('Home', { action: 'confirm' }),
+    );
+    act(() => result.current());
+    expect(impactMedium).toHaveBeenCalled();
+    expect(navigate).toHaveBeenCalledWith('Home');
+  });
+});