chore(app): resolve lint warnings (#990)

transphorm · web-flow · commit 12aff535de9d · 2025-08-29T21:01:24.000-07:00
* chore(app): resolve lint warnings

* update lock

* clean up any types

* fix types

* feedback from cr
diff --git a/app/src/RemoteConfig.shared.ts b/app/src/RemoteConfig.shared.ts
@@ -19,18 +19,20 @@ export interface LocalOverride {
 }
 
 export interface RemoteConfigBackend {
-  getValue(key: string): {
-    asBoolean(): boolean;
-    asNumber(): number;
-    asString(): string;
-    getSource(): string;
-  };
-  getAll(): Record<string, any>;
-  setDefaults(defaults: Record<string, any>): Promise<void> | void;
-  setConfigSettings(settings: any): Promise<void> | void;
+  getValue(key: string): RemoteConfigValue;
+  getAll(): Record<string, RemoteConfigValue>;
+  setDefaults(defaults: Record<string, FeatureFlagValue>): Promise<void> | void;
+  setConfigSettings(settings: Record<string, unknown>): Promise<void> | void;
   fetchAndActivate(): Promise<boolean>;
 }
 
+export interface RemoteConfigValue {
+  asBoolean(): boolean;
+  asNumber(): number;
+  asString(): string;
+  getSource(): string;
+}
+
 export interface StorageBackend {
   getItem(key: string): Promise<string | null>;
   setItem(key: string, value: string): Promise<void>;
diff --git a/app/src/RemoteConfig.web.ts b/app/src/RemoteConfig.web.ts
@@ -8,6 +8,7 @@
 import type {
   FeatureFlagValue,
   RemoteConfigBackend,
+  RemoteConfigValue,
   StorageBackend,
 } from '@/RemoteConfig.shared';
 import {
@@ -37,10 +38,10 @@ const webStorageBackend: StorageBackend = {
 // Mock Firebase Remote Config for web (since Firebase Web SDK for Remote Config is not installed)
 // In a real implementation, you would import and use the Firebase Web SDK
 class MockFirebaseRemoteConfig implements RemoteConfigBackend {
-  private config: Record<string, unknown> = {};
+  private config: Record<string, FeatureFlagValue> = {};
   private settings: Record<string, unknown> = {};
 
-  setDefaults(defaults: Record<string, unknown>) {
+  setDefaults(defaults: Record<string, FeatureFlagValue>) {
     this.config = { ...defaults };
   }
 
@@ -80,8 +81,12 @@ class MockFirebaseRemoteConfig implements RemoteConfigBackend {
     };
   }
 
-  getAll() {
-    return this.config;
+  getAll(): Record<string, RemoteConfigValue> {
+    const result: Record<string, RemoteConfigValue> = {};
+    for (const [key, value] of Object.entries(this.config)) {
+      result[key] = this.getValue(key);
+    }
+    return result;
   }
 }
 
diff --git a/app/src/Sentry.ts b/app/src/Sentry.ts
@@ -15,7 +15,7 @@ import {
 
 export const captureException = (
   error: Error,
-  context?: Record<string, any>,
+  context?: Record<string, unknown>,
 ) => {
   if (isSentryDisabled) {
     return;
@@ -27,7 +27,7 @@ export const captureException = (
 
 export const captureFeedback = (
   feedback: string,
-  context?: Record<string, any>,
+  context?: Record<string, unknown>,
 ) => {
   if (isSentryDisabled) {
     return;
@@ -36,18 +36,18 @@ export const captureFeedback = (
   sentryCaptureFeedback(
     {
       message: feedback,
-      name: context?.name,
-      email: context?.email,
+      name: context?.name as string | undefined,
+      email: context?.email as string | undefined,
       tags: {
-        category: context?.category || 'general',
-        source: context?.source || 'feedback_modal',
+        category: (context?.category as string) || 'general',
+        source: (context?.source as string) || 'feedback_modal',
       },
     },
     {
       captureContext: {
         tags: {
-          category: context?.category || 'general',
-          source: context?.source || 'feedback_modal',
+          category: (context?.category as string) || 'general',
+          source: (context?.source as string) || 'feedback_modal',
         },
       },
     },
@@ -56,7 +56,7 @@ export const captureFeedback = (
 
 export const captureMessage = (
   message: string,
-  context?: Record<string, any>,
+  context?: Record<string, unknown>,
 ) => {
   if (isSentryDisabled) {
     return;
diff --git a/app/src/Sentry.web.ts b/app/src/Sentry.web.ts
@@ -14,7 +14,7 @@ import {
 
 export const captureException = (
   error: Error,
-  context?: Record<string, any>,
+  context?: Record<string, unknown>,
 ) => {
   if (isSentryDisabled) {
     return;
@@ -26,7 +26,7 @@ export const captureException = (
 
 export const captureFeedback = (
   feedback: string,
-  context?: Record<string, any>,
+  context?: Record<string, unknown>,
 ) => {
   if (isSentryDisabled) {
     return;
@@ -35,18 +35,18 @@ export const captureFeedback = (
   sentryCaptureFeedback(
     {
       message: feedback,
-      name: context?.name,
-      email: context?.email,
+      name: context?.name as string | undefined,
+      email: context?.email as string | undefined,
       tags: {
-        category: context?.category || 'general',
-        source: context?.source || 'feedback_modal',
+        category: (context?.category as string) || 'general',
+        source: (context?.source as string) || 'feedback_modal',
       },
     },
     {
       captureContext: {
         tags: {
-          category: context?.category || 'general',
-          source: context?.source || 'feedback_modal',
+          category: (context?.category as string) || 'general',
+          source: (context?.source as string) || 'feedback_modal',
         },
       },
     },
@@ -55,7 +55,7 @@ export const captureFeedback = (
 
 export const captureMessage = (
   message: string,
-  context?: Record<string, any>,
+  context?: Record<string, unknown>,
 ) => {
   if (isSentryDisabled) {
     return;
diff --git a/app/src/components/native/PassportCamera.web.tsx b/app/src/components/native/PassportCamera.web.tsx
@@ -40,7 +40,6 @@ export const PassportCamera: React.FC<PassportCameraProps> = ({
 
   // Web stub - no functionality yet
   useEffect(() => {
-    void _onPassportRead; // noop until web implementation exists
     // Simulate that the component is not ready for web
     if (isMounted) {
       console.warn('PassportCamera: Web implementation not yet available');
diff --git a/app/src/mocks/react-native-gesture-handler.ts b/app/src/mocks/react-native-gesture-handler.ts
@@ -44,15 +44,15 @@ export const Gesture = {
 
 export const GestureDetector: React.FC<{
   children: React.ReactNode;
-  gesture?: any;
+  gesture?: unknown;
 }> = ({ children, gesture: _gesture }) => {
   return createElement('div', {}, children);
 };
 
 // Mock GestureHandlerRootView as a simple wrapper
 export const GestureHandlerRootView: React.FC<{
   children: React.ReactNode;
-  [key: string]: any;
+  [key: string]: unknown;
 }> = ({ children, ...props }) => {
   return createElement('div', props, children);
 };
diff --git a/app/src/mocks/react-native-passport-reader.ts b/app/src/mocks/react-native-passport-reader.ts
@@ -6,11 +6,11 @@
 
 // Mock PassportReader object with analytics methods
 export const PassportReader = {
-  configure: (token: string, enableDebug?: boolean) => {
+  configure: (_token: string, _enableDebug?: boolean) => {
     // No-op for web
     return Promise.resolve();
   },
-  trackEvent: (name: string, properties?: Record<string, unknown>) => {
+  trackEvent: (_name: string, _properties?: Record<string, unknown>) => {
     // No-op for web
     return Promise.resolve();
   },
diff --git a/app/src/providers/passportDataProvider.tsx b/app/src/providers/passportDataProvider.tsx
@@ -239,6 +239,7 @@ export const PassportProvider = ({ children }: PassportProviderProps) => {
       getAvailableTypes,
       getPassportDataAndSecret,
       getSelectedPassportDataAndSecret,
+      selfClient,
     ],
   );
 
diff --git a/app/src/providers/selfClientProvider.tsx b/app/src/providers/selfClientProvider.tsx
@@ -16,6 +16,8 @@ import { unsafe_getPrivateKey } from '@/providers/authProvider';
 import { selfClientDocumentsAdapter } from '@/providers/passportDataProvider';
 import analytics from '@/utils/analytics';
 
+type GlobalCrypto = { crypto?: { subtle?: Crypto['subtle'] } };
+
 /**
  * Provides a configured Self SDK client instance to all descendants.
  *
@@ -61,7 +63,7 @@ export const SelfClientProvider = ({ children }: PropsWithChildren) => {
           data: Uint8Array,
           algo: 'sha256' = 'sha256',
         ): Promise<Uint8Array> {
-          const subtle = (globalThis as any)?.crypto?.subtle;
+          const subtle = (globalThis as GlobalCrypto)?.crypto?.subtle;
           if (!subtle?.digest) {
             throw new Error(
               'WebCrypto subtle.digest is not available; provide a crypto adapter/polyfill for React Native.',
diff --git a/app/src/screens/dev/MockDataScreen.tsx b/app/src/screens/dev/MockDataScreen.tsx
@@ -40,7 +40,6 @@ import SelfDevCard from '@/images/card-dev.svg';
 import IdIcon from '@/images/icons/id_icon.svg';
 import NoteIcon from '@/images/icons/note.svg';
 import { storePassportData } from '@/providers/passportDataProvider';
-import analytics from '@/utils/analytics';
 import {
   black,
   borderColor,
diff --git a/app/src/screens/misc/LoadingScreen.tsx b/app/src/screens/misc/LoadingScreen.tsx
@@ -26,7 +26,7 @@ import { getLoadingScreenText } from '@/utils/proving/loadingScreenStateText';
 import type { ProvingStateType } from '@/utils/proving/provingMachine';
 import { useProvingStore } from '@/utils/proving/provingMachine';
 
-type LoadingScreenProps = StaticScreenProps<{}>;
+type LoadingScreenProps = StaticScreenProps<Record<string, never>>;
 
 // Define all terminal states that should stop animations and haptics
 const terminalStates: ProvingStateType[] = [
diff --git a/app/src/screens/misc/ModalScreen.tsx b/app/src/screens/misc/ModalScreen.tsx
@@ -37,11 +37,11 @@ export interface ModalNavigationParams
   callbackId: number;
 }
 
-export interface ModalParams extends Record<string, any> {
+export interface ModalParams extends Record<string, unknown> {
   titleText: string;
   bodyText: string;
-  buttonText: string;
-  secondaryButtonText?: string;
+  buttonText: React.ReactNode;
+  secondaryButtonText?: React.ReactNode;
   onButtonPress: (() => Promise<void>) | (() => void);
   onModalDismiss: () => void;
   preventDismiss?: boolean;
@@ -119,11 +119,11 @@ const ModalScreen: React.FC<ModalScreenProps> = ({ route: { params } }) => {
           </YStack>
           <YStack gap={12}>
             <PrimaryButton onPress={onButtonPressed}>
-              {params?.buttonText}
+              {(params?.buttonText as React.ReactNode) || ''}
             </PrimaryButton>
             {params?.secondaryButtonText && (
               <SecondaryButton onPress={onClose}>
-                {params?.secondaryButtonText}
+                {(params?.secondaryButtonText as React.ReactNode) || ''}
               </SecondaryButton>
             )}
           </YStack>
diff --git a/app/src/screens/misc/SplashScreen.tsx b/app/src/screens/misc/SplashScreen.tsx
@@ -75,7 +75,7 @@ const SplashScreen: React.FC = ({}) => {
 
       loadDataAndDetermineNextScreen();
     }
-  }, [checkBiometricsAvailable, setBiometricsAvailable]);
+  }, [checkBiometricsAvailable, setBiometricsAvailable, selfClient]);
 
   const handleAnimationFinish = useCallback(() => {
     impactLight();
diff --git a/app/src/screens/passport/NFCMethodSelectionScreen.tsx b/app/src/screens/passport/NFCMethodSelectionScreen.tsx
@@ -129,7 +129,7 @@ const NFCMethodSelectionScreen: React.FC = () => {
     if (selectedMethod === 'can') {
       params.canNumber = canValue;
     }
-    navigation.navigate('PassportNFCScan', params as any);
+    navigation.navigate('PassportNFCScan', params as never);
   };
 
   return (
diff --git a/app/src/screens/passport/PassportNFCScanScreen.tsx b/app/src/screens/passport/PassportNFCScanScreen.tsx
@@ -395,6 +395,7 @@ const PassportNFCScanScreen: React.FC = () => {
     isPacePolling,
     navigation,
     openErrorModal,
+    trackEvent,
   ]);
 
   const navigateToLaunch = useHapticNavigation('Launch', {
diff --git a/app/src/screens/passport/PassportNFCTroubleScreen.tsx b/app/src/screens/passport/PassportNFCTroubleScreen.tsx
@@ -13,7 +13,7 @@ import { Caption } from '@/components/typography/Caption';
 import { useFeedbackAutoHide } from '@/hooks/useFeedbackAutoHide';
 import useHapticNavigation from '@/hooks/useHapticNavigation';
 import SimpleScrolledTitleLayout from '@/layouts/SimpleScrolledTitleLayout';
-import analytics, { flushAllAnalytics } from '@/utils/analytics';
+import { flushAllAnalytics } from '@/utils/analytics';
 import { slate500 } from '@/utils/colors';
 import { sendFeedbackEmail } from '@/utils/email';
 
diff --git a/app/src/screens/passport/UnsupportedPassportScreen.tsx b/app/src/screens/passport/UnsupportedPassportScreen.tsx
@@ -30,6 +30,12 @@ import { notificationError } from '@/utils/haptic';
 
 const { flush: flushAnalytics } = analytics();
 
+type CountryFlagComponent = React.ComponentType<{
+  width: number;
+  height: number;
+}>;
+type CountryFlagsRecord = Record<string, CountryFlagComponent>;
+
 type UnsupportedPassportScreenRouteProp = RouteProp<
   {
     UnsupportedPassport: {
@@ -92,7 +98,9 @@ const UnsupportedPassportScreen: React.FC<UnsupportedPassportScreenProps> = ({
   // Get country flag component dynamically
   const getCountryFlag = (code: string) => {
     try {
-      const FlagComponent = (CountryFlags as any)[code];
+      const FlagComponent = (CountryFlags as unknown as CountryFlagsRecord)[
+        code.toUpperCase()
+      ];
       if (FlagComponent) {
         return FlagComponent;
       }
diff --git a/app/src/screens/prove/ConfirmBelongingScreen.tsx b/app/src/screens/prove/ConfirmBelongingScreen.tsx
@@ -21,7 +21,7 @@ import { Title } from '@/components/typography/Title';
 import useHapticNavigation from '@/hooks/useHapticNavigation';
 import { ExpandableBottomLayout } from '@/layouts/ExpandableBottomLayout';
 import { styles } from '@/screens/prove/ProofRequestStatusScreen';
-import analytics, { flushAllAnalytics, trackNfcEvent } from '@/utils/analytics';
+import { flushAllAnalytics, trackNfcEvent } from '@/utils/analytics';
 import { black, white } from '@/utils/colors';
 import { notificationSuccess } from '@/utils/haptic';
 import {
diff --git a/app/src/screens/prove/ProveScreen.tsx b/app/src/screens/prove/ProveScreen.tsx
@@ -176,6 +176,7 @@ const ProveScreen: React.FC = () => {
       isContentShorterThanScrollView,
       selectedApp,
       provingStore.uuid,
+      trackEvent,
     ],
   );
 
diff --git a/app/src/screens/prove/QRCodeTroubleScreen.tsx b/app/src/screens/prove/QRCodeTroubleScreen.tsx
@@ -9,7 +9,7 @@ import Tips from '@/components/Tips';
 import { Caption } from '@/components/typography/Caption';
 import useHapticNavigation from '@/hooks/useHapticNavigation';
 import SimpleScrolledTitleLayout from '@/layouts/SimpleScrolledTitleLayout';
-import analytics, { flushAllAnalytics } from '@/utils/analytics';
+import { flushAllAnalytics } from '@/utils/analytics';
 import { slate500 } from '@/utils/colors';
 
 const tips: TipProps[] = [
diff --git a/app/src/screens/prove/ViewFinderScreen.tsx b/app/src/screens/prove/ViewFinderScreen.tsx
@@ -110,7 +110,7 @@ const QRCodeViewFinderScreen: React.FC = () => {
         }
       }
     },
-    [doneScanningQR, navigation, navigateToProveScreen],
+    [doneScanningQR, navigation, navigateToProveScreen, trackEvent],
   );
 
   const shouldRenderCamera = !connectionModalVisible && !doneScanningQR;
diff --git a/app/src/screens/settings/CloudBackupScreen.tsx b/app/src/screens/settings/CloudBackupScreen.tsx
@@ -67,7 +67,12 @@ const CloudBackupScreen: React.FC<CloudBackupScreenProps> = ({
           setPending(false);
         },
       }),
-      [loginWithBiometrics, disableBackup, toggleCloudBackupEnabled],
+      [
+        loginWithBiometrics,
+        disableBackup,
+        toggleCloudBackupEnabled,
+        trackEvent,
+      ],
     ),
   );
 
diff --git a/app/src/utils/proving/provingMachine.ts b/app/src/utils/proving/provingMachine.ts
@@ -702,7 +702,7 @@ export const useProvingStore = create<ProvingState>((set, get) => {
       }
     },
 
-    validatingDocument: async (selfClient: SelfClient) => {
+    validatingDocument: async (_selfClient: SelfClient) => {
       _checkActorInitialized(actor);
       // TODO: for the disclosure, we could check that the selfApp is a valid one.
       trackEvent(ProofEvents.VALIDATION_STARTED);
diff --git a/app/tests/src/components/ErrorBoundary.test.tsx b/app/tests/src/components/ErrorBoundary.test.tsx
diff --git a/app/tests/src/providers/selfClientProvider.test.tsx b/app/tests/src/providers/selfClientProvider.test.tsx
diff --git a/yarn.lock b/yarn.lock
