fix: fixed race condition causing events to be lost during initialization (#1103)

* fix: fixed race condition causing events to be lost during initialization

- added unit test cases
- fixed the race condition

* fix: race condition to prevent loss of events during initialisation

- refactored onReady()
- removed unused tests which were written for wrong fix

---------

Co-authored-by: Sunita Prajapati <[email protected]>

Author: sunitaprajapati89

packages/core/src/__tests__/methods/process.test.ts

@@ -68,6 +68,8 @@ describe('process', () => {
     jest.spyOn(client.isReady, 'value', 'get').mockReturnValue(true);
     // @ts-ignore
     await client.onReady();
+    // @ts-ignore
+    await client.processPendingEvents();
     expectedEvent = {
       ...expectedEvent,
       context: { ...store.context.get() },

packages/core/src/analytics.ts

@@ -307,9 +307,13 @@ export class SegmentClient {
         // check if the app was opened from a deep link
         this.trackDeepLinks(),
       ]);
-
       await this.onReady();
       this.isReady.value = true;
+
+      // Process all pending events
+      await this.processPendingEvents();
+      // Trigger manual flush
+      this.flushPolicyExecuter.manualFlush();
     } catch (error) {
       this.reportInternalError(
         new SegmentError(
@@ -561,15 +565,13 @@ export class SegmentClient {
     // Start flush policies
     // This should be done before any pending events are added to the queue so that any policies that rely on events queued can trigger accordingly
     this.setupFlushPolicies();
-
-    // Send all events in the queue
+  }
+  private async processPendingEvents() {
     const pending = await this.store.pendingEvents.get(true);
-    for (const e of pending) {
-      await this.startTimelineProcessing(e);
-      await this.store.pendingEvents.remove(e);
+    for (const event of pending) {
+      await this.startTimelineProcessing(event);
+      await this.store.pendingEvents.remove(event);
     }
-
-    this.flushPolicyExecuter.manualFlush();
   }
 
   async flush(): Promise<void> {