Add code comments

Author: sebastien-rosset

plugins/grib_pi/src/GribReader.cpp

@@ -60,18 +60,14 @@ void GribReader::clean_all_vectors() {
     delete ls;
   }
   mapGribRecords.clear();
-  deletedRecords.clear();
 }
 //-------------------------------------------------------------------------------
 void GribReader::clean_vector(std::vector<GribRecord *> &ls) {
   std::vector<GribRecord *>::iterator it;
   for (it = ls.begin(); it != ls.end(); it++) {
-      GribRecord *ptr = *it;
-      wxLogMessage("clean_vector. About to delete ptr: %p. Already deleted: %d", ptr, deletedRecords.find(ptr) != deletedRecords.end());
-      if(ptr && deletedRecords.find(ptr) == deletedRecords.end()) {
-          delete ptr;
-          deletedRecords.insert(ptr);
-      }
+    wxLogMessage("clean_vector. About to delete ptr: %p", *it);
+    delete *it;
+    *it = NULL;
   }
   ls.clear();
 }

plugins/grib_pi/src/GribReader.h

@@ -132,13 +132,6 @@ class GribReader {
   void clean_vector(std::vector<GribRecord *> &ls);
   void clean_all_vectors();
   std::vector<GribRecord *> *getFirstNonEmptyList();
-  // GribRecords can be shared between different vectors in mapGribRecords.
-  // Several of the storeRecordInMap() calls in readAllGribRecords() can store
-  // the same GribRecord pointer in multiple vectors.
-  // This means when we try to clean up in clean_vector(), we could end up with
-  // double deletes of the same pointer.
-  // To avoid this, we keep track of which GribRecords have been deleted.
-  std::set<GribRecord*> deletedRecords;
 
   // Interpolation between 2 GribRecord
   double get2GribsInterpolatedValueByDate(double px, double py, time_t date,

plugins/grib_pi/src/GribUIDialog.cpp

@@ -143,10 +143,6 @@ GribTimelineRecordSet::GribTimelineRecordSet(unsigned int cnt)
 GribTimelineRecordSet::~GribTimelineRecordSet() {
   // RemoveGribRecords();
   ClearCachedData();
-  // Delete any remaining GribRecords
-  for(int i=0; i<Idx_COUNT; i++) {
-      m_GribRecordPtrArray[i] = NULL;
-  }
 }
 
 void GribTimelineRecordSet::ClearCachedData() {

plugins/grib_pi/src/GribUIDialog.h

@@ -350,7 +350,7 @@ class GRIBFile {
   GribReader *m_pGribReader;
   time_t m_pRefDateTime;
 
-  //    An array of GribRecordSets found in this GRIB file
+  /** An array of GribRecordSets found in this GRIB file. */
   ArrayOfGribRecordSets m_GribRecordSetArray;
 
   int m_nGribRecords;