Use spl_object_id() instead of spl_object_hash() which is deprecated in PHP 8.6

Author: sebastianbergmann

ChangeLog-8.5.md

@@ -2,6 +2,13 @@
 
 All notable changes of the PHPUnit 8.5 release series are documented in this file using the [Keep a CHANGELOG](https://keepachangelog.com/) principles.
 
+## [8.5.54] - 2026-MM-DD
+
+### Changed
+
+* Use `spl_object_id()` instead of `spl_object_hash()` (which will be deprecated in PHP 8.6)
+* Use the error suppression operator (`@`) when calling `DeepCopy\DeepCopy::copy()` because it uses `spl_object_hash()` (which will be deprecated in PHP 8.6)
+
 ## [8.5.53] - 2026-07-06
 
 ### Changed
@@ -386,6 +393,7 @@ All notable changes of the PHPUnit 8.5 release series are documented in this fil
 * [#3967](https://github.com/sebastianbergmann/phpunit/issues/3967): Cannot double interface that extends interface that extends `\Throwable`
 * [#3968](https://github.com/sebastianbergmann/phpunit/pull/3968): Test class run in a separate PHP process are passing when `exit` called inside
 
+[8.5.54]: https://github.com/sebastianbergmann/phpunit/compare/8.5.53...8.5
 [8.5.53]: https://github.com/sebastianbergmann/phpunit/compare/8.5.52...8.5.53
 [8.5.52]: https://github.com/sebastianbergmann/phpunit/compare/8.5.51...8.5.52
 [8.5.51]: https://github.com/sebastianbergmann/phpunit/compare/8.5.50...8.5.51

src/Framework/ExceptionWrapper.php

@@ -11,7 +11,7 @@
 
 use function array_keys;
 use function get_class;
-use function spl_object_hash;
+use function spl_object_id;
 use PHPUnit\Util\Filter;
 use Throwable;
 
@@ -109,7 +109,7 @@ private function originalException(?Throwable $exceptionToStore = null): ?Throwa
     {
         static $originalExceptions;
 
-        $instanceId = spl_object_hash($this);
+        $instanceId = spl_object_id($this);
 
         if ($exceptionToStore) {
             $originalExceptions[$instanceId] = $exceptionToStore;

src/Framework/TestCase.php

@@ -2173,7 +2173,8 @@ private function handleDependencies(): bool
                         $deepCopy = new DeepCopy;
                         $deepCopy->skipUncloneable(false);
 
-                        $this->dependencyInput[$dependency] = $deepCopy->copy($passed[$dependency]['result']);
+                        // The diagnostics are suppressed because myclabs/deep-copy uses spl_object_hash(), which is deprecated since PHP 8.6
+                        $this->dependencyInput[$dependency] = @$deepCopy->copy($passed[$dependency]['result']);
                     } elseif ($shallowClone) {
                         $this->dependencyInput[$dependency] = clone $passed[$dependency]['result'];
                     } else {

src/Runner/Filter/ExcludeGroupFilterIterator.php

@@ -16,8 +16,8 @@
  */
 final class ExcludeGroupFilterIterator extends GroupFilterIterator
 {
-    protected function doAccept(string $hash): bool
+    protected function doAccept(int $id): bool
     {
-        return !in_array($hash, $this->groupTests, true);
+        return !in_array($id, $this->groupTests, true);
     }
 }

src/Runner/Filter/GroupFilterIterator.php

@@ -12,7 +12,7 @@
 use function array_map;
 use function array_merge;
 use function in_array;
-use function spl_object_hash;
+use function spl_object_id;
 use PHPUnit\Framework\TestSuite;
 use RecursiveFilterIterator;
 use RecursiveIterator;
@@ -23,7 +23,7 @@
 abstract class GroupFilterIterator extends RecursiveFilterIterator
 {
     /**
-     * @var string[]
+     * @var int[]
      */
     protected $groupTests = [];
 
@@ -33,12 +33,12 @@ public function __construct(RecursiveIterator $iterator, array $groups, TestSuit
 
         foreach ($suite->getGroupDetails() as $group => $tests) {
             if (in_array((string) $group, $groups, true)) {
-                $testHashes = array_map(
-                    'spl_object_hash',
+                $testIds = array_map(
+                    'spl_object_id',
                     $tests
                 );
 
-                $this->groupTests = array_merge($this->groupTests, $testHashes);
+                $this->groupTests = array_merge($this->groupTests, $testIds);
             }
         }
     }
@@ -51,8 +51,8 @@ public function accept(): bool
             return true;
         }
 
-        return $this->doAccept(spl_object_hash($test));
+        return $this->doAccept(spl_object_id($test));
     }
 
-    abstract protected function doAccept(string $hash);
+    abstract protected function doAccept(int $id);
 }

src/Runner/Filter/IncludeGroupFilterIterator.php

@@ -16,8 +16,8 @@
  */
 final class IncludeGroupFilterIterator extends GroupFilterIterator
 {
-    protected function doAccept(string $hash): bool
+    protected function doAccept(int $id): bool
     {
-        return in_array($hash, $this->groupTests, true);
+        return in_array($id, $this->groupTests, true);
     }
 }

tests/unit/Framework/Constraint/IsEqualTest.php

@@ -10,12 +10,13 @@
 namespace PHPUnit\Framework\Constraint;
 
 use function preg_replace;
-use function spl_object_hash;
+use function spl_object_id;
 use DateTime;
 use DateTimeZone;
 use DOMDocument;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestFailure;
+use SebastianBergmann\RecursionContext\Context;
 use SplObjectStorage;
 use stdClass;
 
@@ -84,8 +85,10 @@ public function isEqualProvider(): array
         $a      = new stdClass;
         $a->foo = 'bar';
         $b      = new stdClass;
-        $ahash  = spl_object_hash($a);
-        $bhash  = spl_object_hash($b);
+        $aid    = spl_object_id($a);
+        $bid    = spl_object_id($b);
+        $ahash  = $this->objectIdentifier($a);
+        $bhash  = $this->objectIdentifier($b);
 
         $c               = new stdClass;
         $c->foo          = 'bar';
@@ -109,8 +112,8 @@ public function isEqualProvider(): array
         $storage1->offsetSet($b);
         $storage2 = new SplObjectStorage;
         $storage2->offsetSet($b);
-        $storage1hash = spl_object_hash($storage1);
-        $storage2hash = spl_object_hash($storage2);
+        $storage1hash = $this->objectIdentifier($storage1);
+        $storage2hash = $this->objectIdentifier($storage2);
 
         $dom1                     = new DOMDocument;
         $dom1->preserveWhiteSpace = false;
@@ -293,15 +296,15 @@ public function isEqualProvider(): array
 +++ Actual
 @@ @@
 -SplObjectStorage Object &{$storage1hash} (
--    '{$ahash}' => Array &0 (
+-    {$aid} => Array &0 (
 -        'obj' => stdClass Object &{$ahash} (
 -            'foo' => 'bar'
 -        )
 -        'inf' => null
 -    )
--    '{$bhash}' => Array &1 (
+-    {$bid} => Array &1 (
 +SplObjectStorage Object &{$storage2hash} (
-+    '{$bhash}' => Array &0 (
++    {$bid} => Array &0 (
          'obj' => stdClass Object &{$bhash} ()
          'inf' => null
      )
@@ -323,4 +326,20 @@ private function trimnl($string)
     {
         return preg_replace('/[ ]*\n/', "\n", $string);
     }
+
+    /**
+     * Returns the identifier that sebastian/exporter uses for an object.
+     *
+     * That identifier is generated by sebastian/recursion-context and is asked
+     * for here instead of being reproduced so that this test does not depend on
+     * how it is generated.
+     *
+     * @param object $object
+     *
+     * @return int|string
+     */
+    private function objectIdentifier($object)
+    {
+        return (new Context)->add($object);
+    }
 }