Wrap termcolor's color api #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted in #72
The
pub use termcolor::Colorwe releasedenv_logger 0.5.0with was a bad call.This PR duplicates the
termcolor::ColorAPI inenv_loggerso breaking changes intermcolorcan be managed with some gymnastics inenv_logger.If a new variant is added to
termcolor::Color:Color::from_termcolorwill returnNoneuntil/unless we have a corresponding variantColor::FromStrwill returnErr::Unrecognizeduntil/unless we have a corresponding variantIf
termcolordrops the concept ofColorcompletely then we have a little more work to do, but it should still all be manageable.This will technically be a breaking change, since our
ParseColorErrorisn't equivalent totermcolor::ParseColorErrorso you couldn't?it andColorisn't equivalent totermcolor::Color, but pragmatically I think this is safe to make in a patch.cc @BurntSushi @briansmith what do you think?