Skip to content

optimize: upgrade druid and add test-druid.yml#5831

Merged
slievrly merged 7 commits intoapache:developfrom
wangliang181230:test-druid
Sep 13, 2023
Merged

optimize: upgrade druid and add test-druid.yml#5831
slievrly merged 7 commits intoapache:developfrom
wangliang181230:test-druid

Conversation

@wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Sep 6, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. upgrade: druid 1.2.6 to 1.2.7 for fix When use druid:1.2.6, the mvn package will field: Could not find artifact com.sun:tools:jar:1.8 #5839
  2. optimize: upgrade druid and add test-druid.yml

test-druid 的action测试成功历史日志:

https://github.com/seata/seata/actions/runs/6094224560

问题记录:

  1. 使用 druid 1.2.171.2.18 两个版本时,seata的单测会卡死,一直在打印NPE异常。原因:druid的BUG。seata的单测正好触发了此bug导致。

druid的BUG在 1.2.19 中已修复,对应的commit:alibaba/druid@6c493f8

图片

Ⅱ. Does this pull request fix one issue?

fixes #5839

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 changed the title add test-druid.yml test: add test-druid.yml Sep 6, 2023
@wangliang181230 wangliang181230 changed the title test: add test-druid.yml optimize: upgrade druid and add test-druid.yml Sep 11, 2023
@wangliang181230 wangliang181230 added this to the 1.8.0 milestone Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #5831 (0d44aba) into develop (6bb865b) will decrease coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5831      +/-   ##
=============================================
- Coverage      48.17%   48.03%   -0.15%     
- Complexity      4120     4121       +1     
=============================================
  Files            761      761              
  Lines          26769    26853      +84     
  Branches        3349     3350       +1     
=============================================
+ Hits           12897    12899       +2     
- Misses         12457    12540      +83     
+ Partials        1415     1414       -1     

see 6 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When use druid:1.2.6, the mvn package will field: Could not find artifact com.sun:tools:jar:1.8

3 participants