feature : add TC exception log appender metric #5396
Merged
slievrly merged 8 commits intoapache:2.xfrom Mar 2, 2023
Merged
Conversation
slievrly
approved these changes
Feb 28, 2023
Member
slievrly
left a comment
There was a problem hiding this comment.
LGTM, add change in 2.0.0.md
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #5396 +/- ##
============================================
- Coverage 48.75% 48.75% -0.01%
- Complexity 4337 4340 +3
============================================
Files 776 778 +2
Lines 27432 27454 +22
Branches 3410 3412 +2
============================================
+ Hits 13375 13384 +9
- Misses 12661 12674 +13
Partials 1396 1396
|
Contributor
Author
done |
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
新增logback的appender,appender并不会直接上报metric,只负责触发event。由metricsubscribe统一上报。
Ⅱ. Does this pull request fix one issue?
fixes #4586
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews