bugfix: fix when TC returns RollbackFailed FailureHandler not executed#5321
Merged
slievrly merged 7 commits intoapache:developfrom Feb 17, 2023
Merged
bugfix: fix when TC returns RollbackFailed FailureHandler not executed#5321slievrly merged 7 commits intoapache:developfrom
slievrly merged 7 commits intoapache:developfrom
Conversation
…, the custom FailureHandler is not executed. (apache#5311)
…, the custom FailureHandler is not executed. (apache#5311)
# Conflicts: # tm/src/main/java/io/seata/tm/api/TransactionalTemplate.java
…, the custom FailureHandler is not executed. (apache#5311)
funky-eyes
added
type: bug
funky-eyes
reviewed
Feb 10, 2023
| case TimeoutRollbacking: | ||
| case TimeoutRollbackRetrying: | ||
| case TimeoutRollbacked: | ||
| case RollbackRetryTimeout: |
Contributor
There was a problem hiding this comment.
RollbackRetryTimeout 应该放在RollbackFailure那块，因为他是一个失败状态，且不会进行重试了
Contributor
Author
There was a problem hiding this comment.
好的，是不是按照下图这样修改
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5321 +/- ##
=============================================
+ Coverage 48.76% 48.79% +0.03%
- Complexity 4173 4176 +3
=============================================
Files 743 743
Lines 26626 26634 +8
Branches 3327 3327
=============================================
+ Hits 12984 12996 +12
+ Misses 12241 12235 -6
- Partials 1401 1403 +2
|
…, the custom FailureHandler is not executed.(apache#5321)
slievrly
reviewed
Feb 17, 2023
Member
slievrly
left a comment
slievrly
left a comment
There was a problem hiding this comment.
onTimeoutRollback has a design flaw, so change it after merged.
slievrly
changed the title
ZhangShiYeChina
added a commit
to ZhangShiYeChina/seata
that referenced
this pull request
Feb 20, 2023
ZhangShiYeChina
added a commit
to ZhangShiYeChina/seata
that referenced
this pull request
Feb 20, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fixes :#5231
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews