bugfix: After 1.6.0, auto-increment of oracle pk columns are no longer supported#5288
Merged
funky-eyes merged 5 commits intoapache:developfrom Feb 3, 2023
Merged
Conversation
d46a927 to
2e49978
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5288 +/- ##
=============================================
+ Coverage 48.73% 48.81% +0.08%
- Complexity 4159 4174 +15
=============================================
Files 743 743
Lines 26590 26608 +18
Branches 3321 3327 +6
=============================================
+ Hits 12958 12989 +31
+ Misses 12232 12219 -13
Partials 1400 1400
|
1 task
funky-eyes
reviewed
Feb 2, 2023
rm-datasource/src/test/java/io/seata/rm/datasource/exec/OracleInsertExecutorTest.java
Outdated
Show resolved
Hide resolved
tuwenlin
reviewed
Feb 2, 2023
rm-datasource/src/main/java/io/seata/rm/datasource/exec/oracle/OracleInsertExecutor.java
Outdated
Show resolved
Hide resolved
isharpever
added a commit
to isharpever/seata
that referenced
this pull request
Feb 3, 2023
1 task
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix:1.6.0~1.6.1,AT模式,当insert语句不包含主键列时,无法获取到oracle的自增主键值。
Ⅱ. Does this pull request fix one issue?
fixes #5264
Ⅲ. Why don't you add test cases (unit test/integration test)?
添加下面几个单测
io.seata.rm.datasource.exec.OracleInsertExecutorTest#testGetPkValues_SinglePk
io.seata.rm.datasource.exec.OracleInsertExecutorTest#testGetPkValues_MultiPk
io.seata.rm.datasource.exec.OracleInsertExecutorTest#testContainsAnyPK
Ⅳ. Describe how to verify it
集成测试验证了下面几种情况
Ⅴ. Special notes for reviews