tests: don't use t.Errorf on regular strings

Linter start complining, switch to `t.Error`

Author: dkropachev

cassandra_test.go

@@ -100,7 +100,7 @@ func TestUseStatementError(t *testing.T) {
 
 	if err := session.Query("USE gocql_test").Exec(); err != nil {
 		if err != ErrUseStmt {
-			t.Fatalf("expected ErrUseStmt, got " + err.Error())
+			t.Fatalf("expected ErrUseStmt, got %v", err)
 		}
 	} else {
 		t.Fatal("expected err, got nil.")
@@ -561,7 +561,7 @@ func TestCAS(t *testing.T) {
 
 	if _, err := session.Query(`DELETE FROM cas_table WHERE title = ? and revid = ? IF last_modified = ?`,
 		title, revid, tenSecondsLater).ScanCAS(); !strings.HasPrefix(err.Error(), "gocql: not enough columns to scan into") {
-		t.Fatalf("delete: was expecting count mismatch error but got: %q", err.Error())
+		t.Fatalf("delete: was expecting count mismatch error but got: %v", err)
 	}
 
 	if applied, err := session.Query(`DELETE FROM cas_table WHERE title = ? and revid = ? IF last_modified = ?`,

compressor_test.go

@@ -137,7 +137,7 @@ func TestSnappyCompressor(t *testing.T) {
 					}
 
 					if bytes.Compare(decoded, frame.Frame) != 0 {
-						t.Fatalf("failed to match the decoded value with the original value")
+						t.Fatal("failed to match the decoded value with the original value")
 					}
 					t.Logf("Compression rate %f", float64(len(encoded))/float64(len(frame.Frame)))
 				})
@@ -156,7 +156,7 @@ func TestSnappyCompressor(t *testing.T) {
 					}
 
 					if len(decoded) == 0 {
-						t.Fatalf("frame was decoded to empty slice")
+						t.Fatal("frame was decoded to empty slice")
 					}
 				})
 			}

debounce/refresh_debouncer_test.go

@@ -214,7 +214,7 @@ func TestErrorBroadcaster_MultipleListeners(t *testing.T) {
 	}()
 	wg.Wait()
 	if loadedVal := result.Load(); loadedVal != nil {
-		t.Errorf(loadedVal.(error).Error())
+		t.Error(loadedVal.(error).Error())
 	}
 }
 
@@ -249,6 +249,6 @@ func TestErrorBroadcaster_StopWithoutBroadcast(t *testing.T) {
 	}()
 	wg.Wait()
 	if loadedVal := result.Load(); loadedVal != nil {
-		t.Errorf(loadedVal.(error).Error())
+		t.Error(loadedVal.(error).Error())
 	}
 }

integration_test.go

@@ -54,7 +54,7 @@ func TestAuthentication(t *testing.T) {
 	session, err := cluster.CreateSession()
 
 	if err != nil {
-		t.Fatalf("Authentication error: %s", err)
+		t.Fatalf("Authentication error: %v", err)
 	}
 
 	session.Close()
@@ -241,10 +241,10 @@ func TestApplicationInformation(t *testing.T) {
 				break
 			}
 			if iter.Close() != nil {
-				t.Fatalf("failed to execute query: %s", iter.Close().Error())
+				t.Fatalf("failed to execute query: %v", iter.Close())
 			}
 			if !found {
-				t.Fatalf("failed to find the application info row")
+				t.Fatal("failed to find the application info row")
 			}
 		})
 	}

policies_integration_test.go

@@ -5,7 +5,6 @@ package gocql
 
 import (
 	"context"
-	"fmt"
 	"testing"
 	"time"
 )
@@ -68,24 +67,24 @@ func TestTokenAwareHostPolicy(t *testing.T) {
 func testIfPolicyInitializedProperly(t *testing.T, cluster *ClusterConfig, policy *tokenAwareHostPolicy) {
 	_, err := cluster.CreateSession()
 	if err != nil {
-		t.Fatalf(fmt.Errorf("faled to create session: %v", err).Error())
+		t.Fatalf("faled to create session: %s", err.Error())
 	}
 	md := policy.getMetadataReadOnly()
 	if md == nil {
-		t.Fatalf("tokenAwareHostPolicy has no metadata")
+		t.Fatal("tokenAwareHostPolicy has no metadata")
 	}
 	if len(md.tokenRing.tokens) == 0 {
-		t.Fatalf("tokenAwareHostPolicy metadata has no tokens")
+		t.Fatal("tokenAwareHostPolicy metadata has no tokens")
 	}
 	if len(md.tokenRing.hosts) == 0 {
-		t.Fatalf("tokenAwareHostPolicy metadata has no hosts")
+		t.Fatal("tokenAwareHostPolicy metadata has no hosts")
 	}
 	if md.tokenRing.partitioner == nil {
-		t.Fatalf("tokenAwareHostPolicy metadata has no partitioner")
+		t.Fatal("tokenAwareHostPolicy metadata has no partitioner")
 	}
 	if cluster.Keyspace != "" {
 		if len(md.replicas[cluster.Keyspace]) == 0 {
-			t.Fatalf("tokenAwareHostPolicy metadata has no replicas in target keyspace")
+			t.Fatal("tokenAwareHostPolicy metadata has no replicas in target keyspace")
 		}
 	}
 }