add 100ms header verification grace period to Clique

Thegaram · Thegaram · commit e9db4648a8fa · 2025-03-03T16:09:59.000+01:00
diff --git a/consensus/clique/clique.go b/consensus/clique/clique.go
@@ -254,8 +254,10 @@ func (c *Clique) verifyHeader(chain consensus.ChainHeaderReader, header *types.H
 	}
 	number := header.Number.Uint64()
 
-	// Don't waste time checking blocks from the future
-	if header.Time > uint64(time.Now().Unix()) {
+	// Don't waste time checking blocks from the future.
+	// We add 100ms leeway since the scroll_worker internal timers might trigger early.
+	now := time.Now()
+	if header.Time > uint64(now.Unix()) && time.Unix(int64(header.Time), 0).Sub(now) > 100*time.Millisecond {
 		return consensus.ErrFutureBlock
 	}
 	// Checkpoint blocks need to enforce zero beneficiary

Original file line number	Diff line number	Diff line change
`@@ -254,8 +254,10 @@ func (c Clique) verifyHeader(chain consensus.ChainHeaderReader, header types.H`
`254`	`254`	`}`
`255`	`255`	`number := header.Number.Uint64()`
`256`	`256`
`257`		`- // Don't waste time checking blocks from the future`
`258`		`- if header.Time > uint64(time.Now().Unix()) {`
	`257`	`+ // Don't waste time checking blocks from the future.`
	`258`	`+ // We add 100ms leeway since the scroll_worker internal timers might trigger early.`
	`259`	`+ now := time.Now()`
	`260`	`+ if header.Time > uint64(now.Unix()) && time.Unix(int64(header.Time), 0).Sub(now) > 100*time.Millisecond {`
`259`	`261`	`return consensus.ErrFutureBlock`
`260`	`262`	`}`
`261`	`263`	`// Checkpoint blocks need to enforce zero beneficiary`