Change in makeRequest method #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patuwwy
force-pushed
the
fix/wait-continue-when-expect
branch
from
f461212 to
d256406
Compare
patuwwy
requested review from
ErykSol,
MichalCz,
alicja-gruzdz and
piotrek6641
MichalCz
approved these changes
Nov 20, 2023
piotrek6641
approved these changes
Nov 21, 2023
patuwwy
force-pushed
the
fix/wait-continue-when-expect
branch
from
d256406 to
8b75121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In this change, modifications were made to the makeRequest method to improve the handling of HTTP requests. Below is a detailed description of the changes:
A new variable
expectedEventwas added, which is set to "response" or "continue" depending on the value ofoptions.headers?.Expect. This change allows for more flexible event management depending on the expected HTTP headers.Logging was changed, adding the event name to the debugging message. Now, instead of logging “making request”, we log “making request and waiting for event”, which gives more information about what event is expected.
The way events are handled by
clientRequestwas also changed. Now instead of always listening for theresponseevent, we listen for the event specified byexpectedEvent.These changes should improve the handling of HTTP requests and provide more flexibility in handling different types of requests. Please review and approve these changes.
Review checks:
These aspects need to be checked by the reviewer: