Skip to content

Commit 02edd75

Browse files
Merge pull request #960 from scramjetorg/fix/all_sequences
Type change in order to achieve coherent structure for displaying
2 parents 4dde0e3 + 86b58aa commit 02edd75

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/adapters/src/docker-instance-adapter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ IComponent {
171171

172172
// eslint-disable-next-line complexity
173173
async run(config: InstanceConfig, instancesServerPort: number, instanceId: string): Promise<ExitCode> {
174-
if (config.type !== "docker") {
174+
if (!(config.type === "docker" && "container" in config)) {
175175
throw new Error("Docker instance adapter run with invalid runner config");
176176
}
177177

packages/types/src/runner-config.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { InstanceArgs } from "./instance";
55
import { PortConfig } from "./sequence-package-json";
66
import { RunnerContainerConfiguration } from "./sth-configuration";
77

8-
type CommonSequenceConfig = {
8+
export type CommonSequenceConfig = {
99
type: string;
1010
engines: Record<string, string>;
1111
id: string;
@@ -45,6 +45,7 @@ export type KubernetesSequenceConfig = CommonSequenceConfig & {
4545
type: "kubernetes"
4646
}
4747

48-
export type SequenceConfig = DockerSequenceConfig | ProcessSequenceConfig | KubernetesSequenceConfig
48+
// eslint-disable-next-line max-len
49+
export type SequenceConfig = DockerSequenceConfig | ProcessSequenceConfig | KubernetesSequenceConfig | CommonSequenceConfig;
4950

5051
export type InstanceConfig = SequenceConfig & { instanceAdapterExitDelay: number, limits: InstanceLimits }

0 commit comments

Comments
 (0)