Add broken tests for issue #1610

Author: gnutix

tests/Fixtures/Doctrine/Entity/UserInterface.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace JMS\Serializer\Tests\Fixtures\Doctrine\Entity;
+
+interface UserInterface
+{
+    public function getId(): int;
+
+    public function getUsername(): string;
+
+    public function isAdmin(): bool;
+}

tests/Fixtures/Doctrine/Entity/UserWithConstructorDefault.php

@@ -0,0 +1,55 @@
+<?php
+
+declare(strict_types=1);
+
+namespace JMS\Serializer\Tests\Fixtures\Doctrine\Entity;
+
+use Doctrine\DBAL\Types\Types;
+use Doctrine\ORM\Mapping as ORM;
+
+/** @ORM\Entity */
+#[ORM\Entity]
+class UserWithConstructorDefault implements UserInterface
+{
+    /**
+     * @ORM\Id
+     * @ORM\Column(type="integer")
+     */
+    #[ORM\Id]
+    #[ORM\Column('id', Types::INTEGER)]
+    private int $id;
+
+    /**
+     * @ORM\Column(type="string")
+     */
+    #[ORM\Column('username', Types::STRING)]
+    private string $username;
+
+    /**
+     * @ORM\Column(type="boolean")
+     */
+    #[ORM\Column('admin', Types::BOOLEAN)]
+    private bool $admin;
+
+    public function __construct(int $id, string $username, bool $admin = false)
+    {
+        $this->id = $id;
+        $this->username = $username;
+        $this->admin = $admin;
+    }
+
+    public function getId(): int
+    {
+        return $this->id;
+    }
+
+    public function getUsername(): string
+    {
+        return $this->username;
+    }
+
+    public function isAdmin(): bool
+    {
+        return $this->admin;
+    }
+}

tests/Fixtures/Doctrine/Entity/UserWithPropertyDefault.php

@@ -0,0 +1,61 @@
+<?php
+
+declare(strict_types=1);
+
+namespace JMS\Serializer\Tests\Fixtures\Doctrine\Entity;
+
+use Doctrine\DBAL\Types\Types;
+use Doctrine\ORM\Mapping as ORM;
+
+/** @ORM\Entity */
+#[ORM\Entity]
+class UserWithPropertyDefault implements UserInterface
+{
+    /**
+     * @ORM\Id
+     * @ORM\Column(type="integer")
+     */
+    #[ORM\Id]
+    #[ORM\Column('id', Types::INTEGER)]
+    private int $id;
+
+    /**
+     * @ORM\Column(type="string")
+     */
+    #[ORM\Column('username', Types::STRING)]
+    private string $username;
+
+    /**
+     * @ORM\Column(type="boolean")
+     */
+    #[ORM\Column('admin', Types::BOOLEAN)]
+    private bool $admin = false;
+
+    public function __construct(int $id, string $username)
+    {
+        $this->id = $id;
+        $this->username = $username;
+    }
+
+    public function getId(): int
+    {
+        return $this->id;
+    }
+
+    public function getUsername(): string
+    {
+        return $this->username;
+    }
+
+    public function isAdmin(): bool
+    {
+        return $this->admin;
+    }
+
+    public function setAdmin(bool $admin): self
+    {
+        $this->admin = $admin;
+
+        return $this;
+    }
+}

tests/Serializer/Doctrine/ObjectConstructorTest.php

@@ -45,6 +45,9 @@
 use JMS\Serializer\Tests\Fixtures\Doctrine\Embeddable\BlogPostSeo;
 use JMS\Serializer\Tests\Fixtures\Doctrine\Entity\Author;
 use JMS\Serializer\Tests\Fixtures\Doctrine\Entity\AuthorExcludedId;
+use JMS\Serializer\Tests\Fixtures\Doctrine\Entity\UserWithPropertyDefault;
+use JMS\Serializer\Tests\Fixtures\Doctrine\Entity\UserInterface;
+use JMS\Serializer\Tests\Fixtures\Doctrine\Entity\UserWithConstructorDefault;
 use JMS\Serializer\Tests\Fixtures\Doctrine\IdentityFields\Server;
 use JMS\Serializer\Tests\Fixtures\Doctrine\PersistentCollection\App;
 use JMS\Serializer\Tests\Fixtures\Doctrine\PersistentCollection\SmartPhone;
@@ -468,6 +471,43 @@ public function testArrayKeyExistsOnObject(): void
         $constructor->construct($this->visitor, $classMetadata, $data, $type, $this->context);
     }
 
+    /**
+     * Test for issue #1610: default values should not overwrite existing entity properties
+     * when deserializing partial payloads with DoctrineObjectConstructor
+     */
+    #[DataProvider('partialDeserializationDoesNotOverwriteExistingEntityPropertiesWithDefaults')]
+    public function testPartialDeserializationDoesNotOverwriteExistingEntityPropertiesWithDefaults(UserInterface $user): void
+    {
+        $serializer = $this->createSerializerWithDoctrineObjectConstructor();
+
+        $em = $this->registry->getManager();
+        assert($em instanceof EntityManager);
+
+        // Create and persist a user with admin=true
+        $em->persist($user);
+        $em->flush();
+        $em->clear();
+
+        // Deserialize a partial payload containing only the id
+        // This simulates receiving a nested object reference like {"author": {"id": 1}}
+        $jsonData = json_encode(['id' => $user->getId()]);
+        $userDeserialized = $serializer->deserialize($jsonData, get_class($user), 'json');
+        assert($userDeserialized instanceof UserWithPropertyDefault);
+
+        // The user should be fetched from the database and its properties should remain unchanged
+        // The admin property should still be true, not reset to the default value of false
+        self::assertEquals($user->getUsername(), $userDeserialized->getUsername(), 'Username should be preserved from database');
+        self::assertTrue($userDeserialized->isAdmin(), 'Admin property should not be reset to default value when deserializing partial payload');
+    }
+
+    public static function partialDeserializationDoesNotOverwriteExistingEntityPropertiesWithDefaults(): array
+    {
+        return [
+            [new UserWithConstructorDefault(1, 'john', true)],
+            [(new UserWithPropertyDefault(2, 'jane'))->setAdmin(true)],
+        ];
+    }
+
     protected function setUp(): void
     {
         $this->visitor = $this->getMockBuilder(DeserializationVisitorInterface::class)->getMock();