Merge pull request #1594 from scyzoryck/fix-rector-ci

Fix rector config

Author: scyzoryck

.github/workflows/static-analysis.yaml

@@ -19,6 +19,8 @@ jobs:
           - "8.0"
           - "8.1"
           - "8.2"
+          - "8.3"
+          - "8.4"
 
     steps:
       - name: "Checkout code"
@@ -42,4 +44,4 @@ jobs:
 
       - name: "Run a static analysis with rector/rector"
         run: "vendor/bin/rector --dry-run"
-        if: ${{ matrix.php-version == 8.2 }}
+        if: ${{ matrix.php-version == 8.4 }}

rector.php

@@ -3,11 +3,8 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Set\ValueObject\LevelSetList;
 
-return static function (RectorConfig $rectorConfig) {
-    $rectorConfig->paths([
-        __DIR__ . '/src',
-    ]);
-    $rectorConfig->phpVersion(74);
-};
+return RectorConfig::configure()->withPaths([
+    __DIR__ . '/src',
+])
+        ->withPhp74Sets();

src/AbstractVisitor.php

@@ -14,7 +14,7 @@
 abstract class AbstractVisitor implements VisitorInterface
 {
     /**
-     * @var GraphNavigatorInterface
+     * @var GraphNavigatorInterface|null
      */
     protected $navigator;
 

src/JsonDeserializationVisitor.php

@@ -204,7 +204,7 @@ public function endVisitingObject(ClassMetadata $metadata, $data, array $type):
      */
     public function getResult($data)
     {
-        unset($this->navigator);
+        $this->navigator = null;
 
         return $data;
     }

src/JsonSerializationVisitor.php

@@ -190,7 +190,7 @@ public function setData(string $key, $value): void
      */
     public function getResult($data)
     {
-        unset($this->navigator);
+        $this->navigator = null;
 
         $result = @json_encode($data, $this->options);
 

src/XmlDeserializationVisitor.php

@@ -449,7 +449,7 @@ public function revertCurrentMetadata()
      */
     public function getResult($data)
     {
-        unset($this->navigator);
+        $this->navigator = null;
 
         return $data;
     }

src/XmlSerializationVisitor.php

@@ -383,7 +383,7 @@ public function endVisitingObject(ClassMetadata $metadata, object $data, array $
      */
     public function getResult($node)
     {
-        unset($this->navigator);
+        $this->navigator = null;
         if (null === $this->document->documentElement) {
             if ($node instanceof \DOMElement) {
                 $this->document->appendChild($node);