Skip to content

Commit d684d69

Browse files
scaleway-botyfodil
andauthored
chore(serverless_jobs): pass image-uri to required (#3979)
Co-authored-by: Yacine FODIL <[email protected]>
1 parent fa9077d commit d684d69

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

cmd/scw/testdata/test-all-usage-jobs-definition-create-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ ARGS:
1010
cpu-limit CPU limit of the job
1111
memory-limit Memory limit of the job (in MiB)
1212
[local-storage-capacity] Local storage capacity of the job (in MiB)
13-
[image-uri] Image to use for the job
13+
image-uri Image to use for the job
1414
[command] Startup command. If empty or not defined, the image's default command is used.
1515
[project-id] Project ID to use. If none is passed the default project ID will be used
1616
[environment-variables.{key}] Environment variables of the job

docs/commands/jobs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ scw jobs definition create [arg=value ...]
4040
| cpu-limit | Required | CPU limit of the job |
4141
| memory-limit | Required | Memory limit of the job (in MiB) |
4242
| local-storage-capacity | | Local storage capacity of the job (in MiB) |
43-
| image-uri | | Image to use for the job |
43+
| image-uri | Required | Image to use for the job |
4444
| command | | Startup command. If empty or not defined, the image's default command is used. |
4545
| project-id | | Project ID to use. If none is passed the default project ID will be used |
4646
| environment-variables.{key} | | Environment variables of the job |

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ require (
2727
github.com/mattn/go-isatty v0.0.20
2828
github.com/moby/buildkit v0.13.2
2929
github.com/opencontainers/go-digest v1.0.0
30-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29
30+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240710142519-7b3cbe4364c1
3131
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
3232
github.com/spf13/cobra v1.8.1
3333
github.com/spf13/pflag v1.0.5

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,8 +463,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
463463
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
464464
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
465465
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
466-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29 h1:BkTk4gynLjguayxrYxZoMZjBnAOh7ntQvUkOFmkMqPU=
467-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
466+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240710142519-7b3cbe4364c1 h1:VtqzoX75ODZe9Sr7l6wkTX+KOvCA9sjbanGXiyGzrPc=
467+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240710142519-7b3cbe4364c1/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
468468
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
469469
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
470470
github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=

internal/namespaces/jobs/v1alpha1/jobs_cli.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func jobsDefinitionCreate() *core.Command {
101101
{
102102
Name: "image-uri",
103103
Short: `Image to use for the job`,
104-
Required: false,
104+
Required: true,
105105
Deprecated: false,
106106
Positional: false,
107107
},

0 commit comments

Comments
 (0)