fix: slice field marshaling out of bound (#3184)

Codelax · web-flow · commit 95798c45ebcb · 2023-06-08T12:51:07.000Z
diff --git a/internal/gofields/gofields.go b/internal/gofields/gofields.go
@@ -49,7 +49,7 @@ func getValue(value reflect.Value, parents []string, path []string) (reflect.Val
 		if err != nil {
 			return reflect.Value{}, fmt.Errorf("trying to access array %s but %s is not a numerical index", strings.Join(parents, "."), path[0])
 		}
-		if idx > value.Len() {
+		if idx >= value.Len() {
 			return reflect.Value{}, fmt.Errorf("trying to access array %s but %d is out of range", strings.Join(parents, "."), idx)
 		}
 		return getValue(value.Index(idx), append(parents, path[0]), path[1:])

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ func getValue(value reflect.Value, parents []string, path []string) (reflect.Val`
`49`	`49`	`if err != nil {`
`50`	`50`	`return reflect.Value{}, fmt.Errorf("trying to access array %s but %s is not a numerical index", strings.Join(parents, "."), path[0])`
`51`	`51`	`}`
`52`		`- if idx > value.Len() {`
	`52`	`+ if idx >= value.Len() {`
`53`	`53`	`return reflect.Value{}, fmt.Errorf("trying to access array %s but %d is out of range", strings.Join(parents, "."), idx)`
`54`	`54`	`}`
`55`	`55`	`return getValue(value.Index(idx), append(parents, path[0]), path[1:])`