fix(k8s): remove oldbinpacking from autoscaler estimator (#887)

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-k8s-cluster-create-usage.stderr.golden

@@ -30,7 +30,7 @@ ARGS:
   [pools.{index}.tags.{index}]                          The tags associated with the pool
   [autoscaler-config.scale-down-disabled]               Disable the cluster autoscaler
   [autoscaler-config.scale-down-delay-after-add]        How long after scale up that scale down evaluation resumes
-  [autoscaler-config.estimator]                         Type of resource estimator to be used in scale up (unknown_estimator | binpacking | oldbinpacking)
+  [autoscaler-config.estimator]                         Type of resource estimator to be used in scale up (unknown_estimator | binpacking)
   [autoscaler-config.expander]                          Type of node group expander to be used in scale up (unknown_expander | random | most_pods | least_waste | priority)
   [autoscaler-config.ignore-daemonsets-utilization]     Ignore DaemonSet pods when calculating resource utilization for scaling down
   [autoscaler-config.balance-similar-node-groups]       Detect similar node groups and balance the number of nodes between them

cmd/scw/testdata/test-all-usage-k8s-cluster-update-usage.stderr.golden

@@ -17,7 +17,7 @@ ARGS:
   [tags.{index}]                                        The new tags associated with the cluster
   [autoscaler-config.scale-down-disabled]               Disable the cluster autoscaler
   [autoscaler-config.scale-down-delay-after-add]        How long after scale up that scale down evaluation resumes
-  [autoscaler-config.estimator]                         Type of resource estimator to be used in scale up (unknown_estimator | binpacking | oldbinpacking)
+  [autoscaler-config.estimator]                         Type of resource estimator to be used in scale up (unknown_estimator | binpacking)
   [autoscaler-config.expander]                          Type of node group expander to be used in scale up (unknown_expander | random | most_pods | least_waste | priority)
   [autoscaler-config.ignore-daemonsets-utilization]     Ignore DaemonSet pods when calculating resource utilization for scaling down
   [autoscaler-config.balance-similar-node-groups]       Detect similar node groups and balance the number of nodes between them

internal/namespaces/k8s/v1/k8s_cli.go

@@ -338,7 +338,7 @@ func k8sClusterCreate() *core.Command {
 				Short:      `Type of resource estimator to be used in scale up`,
 				Required:   false,
 				Positional: false,
-				EnumValues: []string{"unknown_estimator", "binpacking", "oldbinpacking"},
+				EnumValues: []string{"unknown_estimator", "binpacking"},
 			},
 			{
 				Name:       "autoscaler-config.expander",
@@ -510,7 +510,7 @@ func k8sClusterUpdate() *core.Command {
 				Short:      `Type of resource estimator to be used in scale up`,
 				Required:   false,
 				Positional: false,
-				EnumValues: []string{"unknown_estimator", "binpacking", "oldbinpacking"},
+				EnumValues: []string{"unknown_estimator", "binpacking"},
 			},
 			{
 				Name:       "autoscaler-config.expander",