Skip to content

Commit e09743f

Browse files
sbroenneStefan Broenner
andauthored
refactor(chart): simplify nested if-statements in AddTrendline validation (#397)
Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm>
1 parent 084c9c7 commit e09743f

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

src/ExcelMcp.Core/Commands/Chart/ChartCommands.Appearance.cs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -918,20 +918,14 @@ public TrendlineResult AddTrendline(
918918
string? name = null)
919919
{
920920
// Validate type-specific parameters
921-
if (type == TrendlineType.Polynomial)
921+
if (type == TrendlineType.Polynomial && (!order.HasValue || order.Value < 2 || order.Value > 6))
922922
{
923-
if (!order.HasValue || order.Value < 2 || order.Value > 6)
924-
{
925-
throw new ArgumentException("Polynomial trendline requires order parameter (2-6).");
926-
}
923+
throw new ArgumentException("Polynomial trendline requires order parameter (2-6).");
927924
}
928925

929-
if (type == TrendlineType.MovingAverage)
926+
if (type == TrendlineType.MovingAverage && (!period.HasValue || period.Value < 2))
930927
{
931-
if (!period.HasValue || period.Value < 2)
932-
{
933-
throw new ArgumentException("Moving average trendline requires period parameter (2 or greater).");
934-
}
928+
throw new ArgumentException("Moving average trendline requires period parameter (2 or greater).");
935929
}
936930

937931
return batch.Execute((ctx, ct) =>

0 commit comments

Comments
 (0)