Skip to content

Commit 5a2a163

Browse files
committed
Fix duplicate notification endpoint setup in pipeline generation
**Why?** When generating a pipeline, the code optimization introduced by PR awslabs#285 broke the notification_endpoint configuration. When set, it would try to configure the notification in the main generator as well as in the default ADF pipeline generator. **What?** Removing the notification endpoint configuration from the main template, as that is replaced by the default ADF pipeline generator implementation.
1 parent c54cbf3 commit 5a2a163

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

  • src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks

src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/main.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
from aws_cdk import (
88
core
99
)
10-
from cdk_constructs import adf_notifications
1110
from logger import configure_logger
1211

1312
from cdk_stacks.adf_default_pipeline import generate_adf_default_pipeline as generate_default_pipeline, PIPELINE_TYPE as DEFAULT_PIPELINE
@@ -21,9 +20,6 @@ def __init__(self, scope: core.Construct, stack_input: dict, **kwargs) -> None:
2120
LOGGER.info('Pipeline creation/update of %s commenced', stack_input['input']['name'])
2221
_pipeline_type = stack_input['input'].get('params', {}).get('type', DEFAULT_PIPELINE).lower()
2322

24-
if stack_input['input'].get('params', {}).get('notification_endpoint'):
25-
stack_input['input']["topic_arn"] = adf_notifications.Notifications(self, 'adf_notifications', stack_input['input']).topic_arn
26-
2723
self.generate_pipeline(_pipeline_type, stack_input)
2824

2925
def generate_pipeline(self, _pipeline_type, stack_input):

0 commit comments

Comments
 (0)