Skip to content

Fix signature verification #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix signature verification #48

wants to merge 3 commits into from

Conversation

@fauresebast
Copy link

@fauresebast fauresebast commented Jul 31, 2025

AS4 message

  • have a couple of "//wse:Security/wse:BinarySecurityToken" so we need to extract the correct one during signature validation
  • may have ds:Reference for attachments, not following the other Reference validation and must be checked outside

@fauresebast fauresebast marked this pull request as ready for review July 31, 2025 09:21
NathanBerthier
NathanBerthier approved these changes Jul 31, 2025
View reviewed changes
Copy link

@NathanBerthier NathanBerthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💪

@thromera
Copy link

thromera commented Aug 5, 2025

Nice

@fauresebast fauresebast force-pushed the sf/fix-signature-verification branch from c6577e7 to be41233 Compare August 7, 2025 10:29
@fauresebast fauresebast force-pushed the sf/fix-signature-verification branch from be41233 to 07e8524 Compare August 7, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NathanBerthier NathanBerthier NathanBerthier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fauresebast @thromera @NathanBerthier