Skip to content

Conversation

@marcelmamula
Copy link
Contributor

Issue

Issue was detected when downloads were interrupted, which resulted in retry attempt detecting partial file and skipping it.
#39

Root cause:

  • Function _download_file was not deleting partial files (failed checksum) at correct point in time
  • Role detected failure because of checksum, retried running module, which detected file that was not deleted resulting in success.

Changes

  • Move up deletion of file outside of retry conditional
  • Remove retry parameters in role tasks

@marcelmamula marcelmamula self-assigned this Sep 3, 2025
@marcelmamula marcelmamula added the bug Something isn't working label Sep 3, 2025
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't encounter the issue during my testing but the download worked as before, so:

LGTM!

@marcelmamula marcelmamula merged commit 3888bf0 into sap-linuxlab:dev Sep 5, 2025
2 checks passed
@marcelmamula marcelmamula deleted the issue39 branch November 11, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants