maintenance_planner modules: Add option to use Display ID instead of name #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transaction Display ID is always unique and our modules were not using it. This PR adds new function that searches transaction using Name and it will attempt search using Display ID if it finds nothing for Name.
#25
Changes
get_transaction_idthat does one API call instead of 2 that usingget_transaction_id_by_namealong withget_transaction_id_by_display_idwould do.destarg in modulemaintenance_planner_stack_xml_downloadwas renamed todownload_pathto align it with breaking changes in software_center_download: Add option to search for latest packages #28Change reverted by later PR #34, prior to release