diff --git a/.ansible-lint b/.ansible-lint index ee1640923..fc8726c61 100644 --- a/.ansible-lint +++ b/.ansible-lint @@ -1,28 +1,26 @@ --- -# Collection wide lint-file -# DO NOT CHANGE +## Collection wide ansible-lint configuration file. +# Changes for ansible-lint v25.7.0+ +# - Always executed from collection root using collection configuration. +# - .ansible-lint-ignore can be used to ignore files, not folders. +## Execution examples: +# ansible-lint +# ansible-lint roles/sap_swpm +# ansible-lint roles/sap_install_media_detect -c roles/sap_install_media_detect/.ansible-lint + exclude_paths: - .ansible/ - .cache/ - .github/ - #- docs/ - changelogs/ - playbooks/ - - roles/sap_anydb_install_oracle - #- roles/sap_general_preconfigure - #- roles/sap_ha_install_anydb_ibmdb2 - #- roles/sap_ha_install_hana_hsr - #- roles/sap_ha_pacemaker_cluster - #- roles/sap_hana_install - #- roles/sap_hana_preconfigure - #- roles/sap_hostagent - #- roles/sap_install_media_detect - #- roles/sap_netweaver_preconfigure - #- roles/sap_storage_setup - #- roles/sap_swpm - tests/ + # Roles which need to be excluded until their linting errors are resolved: + - roles/sap_anydb_install_oracle + enable_list: - yaml + skip_list: # We don't want to enforce new Ansible versions for Galaxy: - meta-runtime[unsupported-version] diff --git a/.ansible-lint-ignore b/.ansible-lint-ignore new file mode 100644 index 000000000..cd257d43e --- /dev/null +++ b/.ansible-lint-ignore @@ -0,0 +1,9 @@ +# This file is replacement for role specific .ansible-lint files with skip_list and warn_list. +# Path has to point to a file because folders or wildcards are not accepted. + +# 'sap_install_media_detect' sets variables used by 'sap_swpm' and 'sap_hana_install' +roles/sap_install_media_detect/tasks/set_global_vars.yml var-naming[no-role-prefix] +roles/sap_install_media_detect/tasks/find_files_after_extraction.yml var-naming[no-role-prefix] + +# 'sap_ha_pacemaker_cluster' sets variables used by LSR role 'ha_cluster'. +roles/sap_ha_pacemaker_cluster/tasks/construct_final_hacluster_vars.yml var-naming[no-role-prefix] diff --git a/.github/workflows/ansible-lint-sap_general_preconfigure.yml b/.github/workflows/ansible-lint-sap_general_preconfigure.yml index 976b108c6..b372b459d 100644 --- a/.github/workflows/ansible-lint-sap_general_preconfigure.yml +++ b/.github/workflows/ansible-lint-sap_general_preconfigure.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_general_preconfigure +name: Ansible Lint - sap_general_preconfigure on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_general_preconfigure/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_general_preconfigure/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_general_preconfigure + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_general_preconfigure + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_ha_install_hana_hsr.yml b/.github/workflows/ansible-lint-sap_ha_install_hana_hsr.yml index 55808b9cd..f4bc1b932 100644 --- a/.github/workflows/ansible-lint-sap_ha_install_hana_hsr.yml +++ b/.github/workflows/ansible-lint-sap_ha_install_hana_hsr.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_ha_install_hana_hsr +name: Ansible Lint - sap_ha_install_hana_hsr on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_ha_install_hana_hsr/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_ha_install_hana_hsr/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_ha_install_hana_hsr + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_ha_install_hana_hsr + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_ha_pacemaker_cluster.yml b/.github/workflows/ansible-lint-sap_ha_pacemaker_cluster.yml index 25f8321c0..31df2838f 100644 --- a/.github/workflows/ansible-lint-sap_ha_pacemaker_cluster.yml +++ b/.github/workflows/ansible-lint-sap_ha_pacemaker_cluster.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_ha_pacemaker_cluster +name: Ansible Lint - sap_ha_pacemaker_cluster on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_ha_pacemaker_cluster/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_ha_pacemaker_cluster/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_ha_pacemaker_cluster + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_ha_pacemaker_cluster + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_hana_install.yml b/.github/workflows/ansible-lint-sap_hana_install.yml index 86c18b998..354290afc 100644 --- a/.github/workflows/ansible-lint-sap_hana_install.yml +++ b/.github/workflows/ansible-lint-sap_hana_install.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_hana_install +name: Ansible Lint - sap_hana_install on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_hana_install/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_hana_install/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_hana_install + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_hana_install + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_hana_preconfigure.yml b/.github/workflows/ansible-lint-sap_hana_preconfigure.yml index 02e2a0d57..5b517c740 100644 --- a/.github/workflows/ansible-lint-sap_hana_preconfigure.yml +++ b/.github/workflows/ansible-lint-sap_hana_preconfigure.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_hana_preconfigure +name: Ansible Lint - sap_hana_preconfigure on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_hana_preconfigure/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_hana_preconfigure/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_hana_preconfigure + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_hana_preconfigure + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_install_media_detect.yml b/.github/workflows/ansible-lint-sap_install_media_detect.yml index cae593c92..4bade41d7 100644 --- a/.github/workflows/ansible-lint-sap_install_media_detect.yml +++ b/.github/workflows/ansible-lint-sap_install_media_detect.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_install_media_detect +name: Ansible Lint - sap_install_media_detect on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_install_media_detect/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_install_media_detect/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_install_media_detect + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_install_media_detect + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml b/.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml index 496a22758..3dc058aae 100644 --- a/.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml +++ b/.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_maintain_etc_hosts +name: Ansible Lint - sap_maintain_etc_hosts on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_maintain_etc_hosts/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_maintain_etc_hosts/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_maintain_etc_hosts + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_maintain_etc_hosts + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_netweaver_preconfigure.yml b/.github/workflows/ansible-lint-sap_netweaver_preconfigure.yml index ec07a3387..6d4521bba 100644 --- a/.github/workflows/ansible-lint-sap_netweaver_preconfigure.yml +++ b/.github/workflows/ansible-lint-sap_netweaver_preconfigure.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_netweaver_preconfigure +name: Ansible Lint - sap_netweaver_preconfigure on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_netweaver_preconfigure/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_netweaver_preconfigure/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_netweaver_preconfigure + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_netweaver_preconfigure + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_reusable_workflow.yml b/.github/workflows/ansible-lint-sap_reusable_workflow.yml deleted file mode 100644 index 63e590f96..000000000 --- a/.github/workflows/ansible-lint-sap_reusable_workflow.yml +++ /dev/null @@ -1,36 +0,0 @@ ---- - -# Workflow for ansible-lint of a role - -name: ansible-lint reusable workflow for role - -on: - workflow_call: - inputs: - role: - required: true - type: string - -jobs: - ansible-lint: - runs-on: ubuntu-latest - - steps: - - name: Check out the code - uses: actions/checkout@v4 - - - name: Set up Python 3 - uses: actions/setup-python@v5 - with: - python-version: '3.12' - - - name: Install test dependencies - run: | - pip3 install ansible==9.1.0 - pip3 install ansible-compat==4.1.11 - pip3 install ansible-core==2.16.2 - pip3 install ansible-lint==6.22.2 - - - name: Run ansible-lint - working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/${{ inputs.role }} - run: ansible-lint diff --git a/.github/workflows/ansible-lint-sap_storage_setup.yml b/.github/workflows/ansible-lint-sap_storage_setup.yml index 2ba528a32..61757da21 100644 --- a/.github/workflows/ansible-lint-sap_storage_setup.yml +++ b/.github/workflows/ansible-lint-sap_storage_setup.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_storage_setup +name: Ansible Lint - sap_storage_setup on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_storage_setup/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_storage_setup/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_storage_setup + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_storage_setup + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint-sap_swpm.yml b/.github/workflows/ansible-lint-sap_swpm.yml index d9b603413..9913ea86e 100644 --- a/.github/workflows/ansible-lint-sap_swpm.yml +++ b/.github/workflows/ansible-lint-sap_swpm.yml @@ -1,8 +1,5 @@ --- - -# Workflow for ansible-lint of a role, using reusable workflow - -name: ansible-lint of the role sap_swpm +name: Ansible Lint - sap_swpm on: push: @@ -17,15 +14,23 @@ on: - dev paths: - 'roles/sap_swpm/**' + workflow_dispatch: - branches: - - main - - dev - paths: - - 'roles/sap_swpm/**' jobs: - ansible-lint-exec: - uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main - with: - role: sap_swpm + ansible-lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v5 + + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 + with: + # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'. + # Role specific .ansible-lint can be added with argument '-c'. + args: roles/sap_swpm + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index d43bc8a1f..ba2473f5f 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -1,12 +1,10 @@ --- - -# Workflow for ansible-lint of the collection - -name: ansible-lint of the collection +name: Ansible Lint - Collection on: schedule: - - cron: '31 13 * * 1' + # This is 03:05 UTC, which is 5:05 AM in Prague/CEST. + - cron: '5 3 * * 1' workflow_dispatch: @@ -15,39 +13,12 @@ jobs: runs-on: ubuntu-latest steps: - - name: Check out the code - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - - name: Set up Python 3 - uses: actions/setup-python@v5 + # Use @v25 to automatically track the latest release from the year 2025. + # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH). + # Avoid using @main, which can introduce breaking changes unexpectedly. + - uses: ansible/ansible-lint@v25 with: - python-version: '3.12' - - - name: Install test dependencies - run: | - pip3 install ansible==9.1.0 - pip3 install ansible-compat==4.1.10 - pip3 install ansible-core==2.16.2 - pip3 install ansible-lint==6.22.1 - -# - name: Install collection dependencies -# run: ansible-galaxy collection install community.general - - - name: Move the collection to the correct location - Create new directory - run: mkdir -p /home/runner/.ansible/collections/ansible_collections/community - - - name: Move the collection to the correct location - Move the collection - working-directory: /home/runner/ - run: mv /home/runner/work/community.sap_install/community.sap_install /home/runner/.ansible/collections/ansible_collections/community - - - name: Move the collection to the correct location - Rename the directory - working-directory: /home/runner/ - run: mv /home/runner/.ansible/collections/ansible_collections/community/community.sap_install /home/runner/.ansible/collections/ansible_collections/community/sap_install - - - name: Run ansible-lint - working-directory: /home/runner/.ansible/collections/ansible_collections/community/sap_install - run: ansible-lint - - - name: Move the collection to its previous location - working-directory: /home/runner/ - run: mv /home/runner/.ansible/collections/ansible_collections/community/sap_install /home/runner/work/community.sap_install/community.sap_install + # Use the shared requirements file from the collection root for dependency context. + requirements_file: ./requirements.yml diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml index be39f1101..ed92b5b4c 100644 --- a/.github/workflows/codespell.yml +++ b/.github/workflows/codespell.yml @@ -1,5 +1,4 @@ --- - name: CodeSpell on: @@ -10,13 +9,17 @@ on: branches: - dev + workflow_dispatch: + jobs: codespell: name: Check for spelling errors runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: codespell-project/actions-codespell@master + - uses: actions/checkout@v5 + + - uses: codespell-project/actions-codespell@v2 with: + # lowercase only ignore_words_list: aas,hsa,te,chage,addopt,sybsystem,uptodate diff --git a/roles/sap_anydb_install_oracle/.ansible-lint b/roles/sap_anydb_install_oracle/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_anydb_install_oracle/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_anydb_install_oracle/.yamllint.yml b/roles/sap_anydb_install_oracle/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_anydb_install_oracle/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_general_preconfigure/.ansible-lint b/roles/sap_general_preconfigure/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_general_preconfigure/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_general_preconfigure/.yamllint.yml b/roles/sap_general_preconfigure/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_general_preconfigure/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_ha_install_anydb_ibmdb2/.ansible-lint b/roles/sap_ha_install_anydb_ibmdb2/.ansible-lint deleted file mode 100644 index 63122b8f9..000000000 --- a/roles/sap_ha_install_anydb_ibmdb2/.ansible-lint +++ /dev/null @@ -1,7 +0,0 @@ ---- -enable_list: - - yaml -skip_list: - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work diff --git a/roles/sap_ha_install_anydb_ibmdb2/.yamllint.yml b/roles/sap_ha_install_anydb_ibmdb2/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_ha_install_anydb_ibmdb2/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_ha_install_hana_hsr/.ansible-lint b/roles/sap_ha_install_hana_hsr/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_ha_install_hana_hsr/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_ha_install_hana_hsr/.yamllint.yml b/roles/sap_ha_install_hana_hsr/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_ha_install_hana_hsr/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_ha_pacemaker_cluster/.ansible-lint b/roles/sap_ha_pacemaker_cluster/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_ha_pacemaker_cluster/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_ha_pacemaker_cluster/.yamllint.yml b/roles/sap_ha_pacemaker_cluster/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_ha_pacemaker_cluster/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_hana_install/.ansible-lint b/roles/sap_hana_install/.ansible-lint deleted file mode 100644 index a75ef53a9..000000000 --- a/roles/sap_hana_install/.ansible-lint +++ /dev/null @@ -1,17 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] - - yaml[line-length] diff --git a/roles/sap_hana_install/.yamllint.yml b/roles/sap_hana_install/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_hana_install/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_hana_preconfigure/.ansible-lint b/roles/sap_hana_preconfigure/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_hana_preconfigure/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_hana_preconfigure/.yamllint.yml b/roles/sap_hana_preconfigure/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_hana_preconfigure/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_hostagent/.ansible-lint b/roles/sap_hostagent/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_hostagent/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_hostagent/.yamllint.yml b/roles/sap_hostagent/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_hostagent/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_install_media_detect/.ansible-lint b/roles/sap_install_media_detect/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_install_media_detect/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_install_media_detect/.yamllint.yml b/roles/sap_install_media_detect/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_install_media_detect/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_maintain_etc_hosts/.ansible-lint b/roles/sap_maintain_etc_hosts/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_maintain_etc_hosts/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_maintain_etc_hosts/.yamllint.yml b/roles/sap_maintain_etc_hosts/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_maintain_etc_hosts/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_netweaver_preconfigure/.ansible-lint b/roles/sap_netweaver_preconfigure/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_netweaver_preconfigure/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_netweaver_preconfigure/.yamllint.yml b/roles/sap_netweaver_preconfigure/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_netweaver_preconfigure/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_storage_setup/.ansible-lint b/roles/sap_storage_setup/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_storage_setup/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_storage_setup/.yamllint.yml b/roles/sap_storage_setup/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_storage_setup/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true diff --git a/roles/sap_swpm/.ansible-lint b/roles/sap_swpm/.ansible-lint deleted file mode 100644 index 8a5df4d43..000000000 --- a/roles/sap_swpm/.ansible-lint +++ /dev/null @@ -1,16 +0,0 @@ ---- -exclude_paths: - - tests/ -enable_list: - - yaml -skip_list: - # We don't want to enforce new Ansible versions for Galaxy: - - meta-runtime[unsupported-version] - # We do not want to use checks which are marked as experimental: - - experimental - # We use ignore_errors for all the assert tasks, which should be acceptable: - - ignore-errors - # We want to allow single digit version numbers in a role's meta/main.yml file: - - schema - # Allow templating inside name because it creates more detailed output: - - name[template] diff --git a/roles/sap_swpm/.yamllint.yml b/roles/sap_swpm/.yamllint.yml deleted file mode 100644 index ee4457cfd..000000000 --- a/roles/sap_swpm/.yamllint.yml +++ /dev/null @@ -1,27 +0,0 @@ -# SPDX-License-Identifier: Apache-2.0 ---- -# Based on ansible-lint config -extends: default - -rules: - braces: {max-spaces-inside: 1, level: error} - brackets: {max-spaces-inside: 1, level: error} -# colons: {max-spaces-after: -1, level: error} -# commas: {max-spaces-after: -1, level: error} - comments: - require-starting-space: false - min-spaces-from-content: 1 - comments-indentation: disable -# document-start: disable -# empty-lines: {max: 3, level: error} -# hyphens: {level: error} -# indentation: disable -# key-duplicates: enable - line-length: disable -# new-line-at-end-of-file: disable -# new-lines: {type: unix} -# trailing-spaces: disable - truthy: disable - octal-values: - forbid-implicit-octal: true - forbid-explicit-octal: true