feat(ui): wire Call and Canvas into entity tabs, clean dead_code annotations

- Add Call and Canvas variants to EntityTab enum
- Create EntityCallContent wrapping CallView in entity pages
- Create EntityCanvasContent wrapping CanvasView in entity pages
- Call tab available on Channels, Groups, Organizations, Persons
- Canvas tab available on Projects
- Remove dead_code annotations from call, canvas, and drive components
- Remove truly unused items: SortColumn::Type, dialog functions
- Move test-only utilities behind #[cfg(test)]

Co-Authored-By: Claude Opus 4.6 <[email protected]>

Author: dirvine

communitas-dioxus/src/components/call/call_view.rs

@@ -295,7 +295,6 @@ pub fn CallView(props: CallViewProps) -> Element {
 }
 
 /// Format duration in MM:SS or HH:MM:SS format.
-#[allow(dead_code)] // Used by CallView components which aren't wired into routes yet
 fn format_duration(seconds: u64) -> String {
     let hours = seconds / 3600;
     let minutes = (seconds % 3600) / 60;

communitas-dioxus/src/components/call/screen_share_picker.rs

@@ -254,7 +254,6 @@ pub fn ScreenSharePicker(props: ScreenSharePickerProps) -> Element {
 
 // Note: Used in the rsx! macro for selected_tab signal and match
 #[derive(Clone, Copy, PartialEq, Debug)]
-#[allow(dead_code)]
 enum SourceTab {
     Monitors,
     Windows,

communitas-dioxus/src/components/canvas/canvas_view.rs

@@ -333,7 +333,6 @@ pub fn CanvasView(props: CanvasViewProps) -> Element {
 }
 
 /// Render remote cursors overlay if any are present.
-#[allow(dead_code)]
 fn render_remote_cursors(
     cursors: &[communitas_ui_api::canvas::RemoteCursor],
     viewport_width: f32,
@@ -444,7 +443,6 @@ fn CanvasElement(props: CanvasElementProps) -> Element {
 }
 
 /// Render the content of an element based on its kind.
-#[allow(dead_code)]
 fn render_element_content(kind: &ElementKindView, transform: &TransformView) -> Element {
     match kind {
         ElementKindView::Text {

communitas-dioxus/src/components/canvas/history_scrubber.rs

@@ -160,7 +160,7 @@ fn HistoryEntryDot(props: HistoryEntryDotProps) -> Element {
 }
 
 /// Get icon for history action type.
-#[allow(dead_code)]
+#[allow(dead_code)] // Called from RSX macro in HistoryEntryDot component
 fn action_icon(action_type: HistoryActionType) -> &'static str {
     match action_type {
         HistoryActionType::AddElement => "+",

communitas-dioxus/src/components/canvas/offline_indicator.rs

@@ -237,7 +237,7 @@ fn OperationItem(props: OperationItemProps) -> Element {
 }
 
 /// Get icon for operation type.
-#[allow(dead_code)]
+#[allow(dead_code)] // Called from RSX macro in OperationItem component
 fn operation_icon(op_type: OperationType) -> &'static str {
     match op_type {
         OperationType::AddElement => "➕",

communitas-dioxus/src/components/canvas/remote_cursors.rs

@@ -70,7 +70,6 @@ pub fn RemoteCursors(props: RemoteCursorsProps) -> Element {
 }
 
 /// Calculate opacity based on last activity time.
-#[allow(dead_code)]
 fn calculate_opacity(last_active: i64, current_time: i64, timeout: i64) -> f32 {
     if current_time == 0 {
         return 1.0;
@@ -170,7 +169,6 @@ fn RemoteCursorMarker(props: RemoteCursorMarkerProps) -> Element {
 }
 
 /// Get short abbreviation for tool name.
-#[allow(dead_code)]
 fn tool_abbreviation(tool: &str) -> &str {
     match tool.to_lowercase().as_str() {
         "select" => "S",
@@ -232,7 +230,7 @@ pub fn CollaboratorList(props: CollaboratorListProps) -> Element {
 }
 
 /// Get initials from a name.
-#[allow(dead_code)]
+#[allow(dead_code)] // Called from RSX macro in CollaboratorList component
 fn initials(name: &str) -> String {
     name.split_whitespace()
         .filter_map(|word| word.chars().next())
@@ -245,19 +243,6 @@ fn initials(name: &str) -> String {
 mod tests {
     use super::*;
 
-    #[allow(dead_code)]
-    fn make_cursor(user_id: &str, name: &str, x: f32, y: f32, color: &str) -> RemoteCursor {
-        RemoteCursor {
-            user_id: user_id.to_string(),
-            user_name: name.to_string(),
-            x,
-            y,
-            color: color.to_string(),
-            last_active: 1000,
-            tool: None,
-        }
-    }
-
     #[test]
     fn initials_extraction() {
         assert_eq!(initials("Alice Smith"), "AS");

communitas-dioxus/src/components/canvas/toolbar.rs

@@ -212,7 +212,7 @@ fn ToolButton(props: ToolButtonProps) -> Element {
 }
 
 /// Get the emoji icon for a tool type.
-#[allow(dead_code)]
+#[allow(dead_code)] // Called from RSX macro in ToolButton component
 fn tool_icon(tool: ToolType) -> &'static str {
     match tool {
         ToolType::Select => "↖",

communitas-dioxus/src/components/drive/browser.rs

@@ -29,8 +29,6 @@ pub enum SortColumn {
     Name,
     Size,
     Modified,
-    #[allow(dead_code)]
-    Type,
 }
 
 /// Sort direction.

communitas-dioxus/src/components/drive/file_list.rs

@@ -64,11 +64,6 @@ pub fn FileList(props: FileListProps) -> Element {
             SortColumn::Name => a.name.to_lowercase().cmp(&b.name.to_lowercase()),
             SortColumn::Size => a.size_bytes.cmp(&b.size_bytes),
             SortColumn::Modified => a.modified_at.cmp(&b.modified_at),
-            SortColumn::Type => {
-                let a_type = a.mime_type.as_deref().unwrap_or("");
-                let b_type = b.mime_type.as_deref().unwrap_or("");
-                a_type.cmp(b_type)
-            }
         };
 
         match props.sort_direction {

communitas-dioxus/src/components/drive/file_picker.rs

@@ -7,7 +7,7 @@
 //! - Last used directory memory
 
 use dioxus::prelude::*;
-use native_dialog::{FileDialog, MessageDialog, MessageType};
+use native_dialog::FileDialog;
 use std::path::PathBuf;
 use tracing::{debug, info, warn};
 
@@ -20,43 +20,43 @@ pub struct FileFilter {
     pub extensions: &'static [&'static str],
 }
 
-#[allow(dead_code)]
 impl FileFilter {
-    /// Common filter for image files.
+    /// Common filter for all files.
+    pub const ALL: Self = Self {
+        name: "All Files",
+        extensions: &["*"],
+    };
+
+    // Test-only constants
+    #[cfg(test)]
     pub const IMAGES: Self = Self {
         name: "Images",
         extensions: &["png", "jpg", "jpeg", "gif", "webp", "bmp", "ico", "svg"],
     };
 
-    /// Common filter for document files.
+    #[cfg(test)]
     pub const DOCUMENTS: Self = Self {
         name: "Documents",
         extensions: &["pdf", "doc", "docx", "txt", "rtf", "odt", "md"],
     };
 
-    /// Common filter for video files.
+    #[cfg(test)]
     pub const VIDEOS: Self = Self {
         name: "Videos",
         extensions: &["mp4", "mkv", "avi", "mov", "webm", "m4v"],
     };
 
-    /// Common filter for audio files.
+    #[cfg(test)]
     pub const AUDIO: Self = Self {
         name: "Audio",
         extensions: &["mp3", "wav", "flac", "ogg", "m4a", "aac"],
     };
 
-    /// Common filter for archive files.
+    #[cfg(test)]
     pub const ARCHIVES: Self = Self {
         name: "Archives",
         extensions: &["zip", "tar", "gz", "7z", "rar", "xz"],
     };
-
-    /// Common filter for all files.
-    pub const ALL: Self = Self {
-        name: "All Files",
-        extensions: &["*"],
-    };
 }
 
 /// Result of a file picker operation.
@@ -70,14 +70,14 @@ pub enum PickerResult {
     Error(String),
 }
 
-#[allow(dead_code)]
+
+// Test-only methods for PickerResult
+#[cfg(test)]
 impl PickerResult {
-    /// Returns true if files were selected.
     pub fn has_selection(&self) -> bool {
         matches!(self, Self::Selected(files) if !files.is_empty())
     }
 
-    /// Returns the selected files, or an empty vec.
     pub fn files(&self) -> Vec<PathBuf> {
         match self {
             Self::Selected(files) => files.clone(),
@@ -113,19 +113,7 @@ impl Default for PickerConfig {
     }
 }
 
-#[allow(dead_code)]
 impl PickerConfig {
-    /// Create a config for single file selection.
-    pub fn single_file() -> Self {
-        Self {
-            title: "Select File".to_string(),
-            multiple: false,
-            directory: false,
-            filters: vec![FileFilter::ALL],
-            start_directory: None,
-        }
-    }
-
     /// Create a config for multi-file selection.
     pub fn multiple_files() -> Self {
         Self {
@@ -137,58 +125,48 @@ impl PickerConfig {
         }
     }
 
-    /// Create a config for directory selection.
-    pub fn directory() -> Self {
-        Self {
-            title: "Select Folder".to_string(),
-            multiple: false,
-            directory: true,
-            filters: vec![],
-            start_directory: None,
-        }
+    /// Builder: set the title.
+    pub fn with_title(mut self, title: impl Into<String>) -> Self {
+        self.title = title.into();
+        self
     }
 
-    /// Create a config for image file selection.
-    pub fn images() -> Self {
+    // Test-only builder methods
+    #[cfg(test)]
+    pub fn single_file() -> Self {
         Self {
-            title: "Select Images".to_string(),
-            multiple: true,
+            title: "Select File".to_string(),
+            multiple: false,
             directory: false,
-            filters: vec![FileFilter::IMAGES, FileFilter::ALL],
+            filters: vec![FileFilter::ALL],
             start_directory: None,
         }
     }
 
-    /// Create a config for document selection.
-    pub fn documents() -> Self {
+    #[cfg(test)]
+    pub fn directory() -> Self {
         Self {
-            title: "Select Documents".to_string(),
-            multiple: true,
-            directory: false,
-            filters: vec![FileFilter::DOCUMENTS, FileFilter::ALL],
+            title: "Select Folder".to_string(),
+            multiple: false,
+            directory: true,
+            filters: vec![],
             start_directory: None,
         }
     }
 
-    /// Builder: set the title.
-    pub fn with_title(mut self, title: impl Into<String>) -> Self {
-        self.title = title.into();
-        self
-    }
-
-    /// Builder: enable multiple selection.
+    #[cfg(test)]
     pub fn with_multiple(mut self, multiple: bool) -> Self {
         self.multiple = multiple;
         self
     }
 
-    /// Builder: set starting directory.
+    #[cfg(test)]
     pub fn with_start_directory(mut self, dir: PathBuf) -> Self {
         self.start_directory = Some(dir);
         self
     }
 
-    /// Builder: add a file filter.
+    #[cfg(test)]
     pub fn with_filter(mut self, filter: FileFilter) -> Self {
         self.filters.push(filter);
         self
@@ -327,77 +305,6 @@ pub fn open_file_picker(config: &PickerConfig) -> PickerResult {
     }
 }
 
-/// Open a save file dialog.
-#[allow(dead_code)]
-pub fn open_save_picker(title: &str, default_name: &str, filters: &[FileFilter]) -> PickerResult {
-    let start_dir = get_last_directory()
-        .or_else(dirs::download_dir)
-        .or_else(dirs::home_dir);
-
-    debug!(
-        target: "ui.drive.picker",
-        title = %title,
-        default_name = %default_name,
-        "Opening save picker"
-    );
-
-    let mut dialog = FileDialog::new().set_filename(default_name);
-
-    if let Some(ref dir) = start_dir {
-        dialog = dialog.set_location(dir);
-    }
-
-    for filter in filters {
-        dialog = dialog.add_filter(filter.name, filter.extensions);
-    }
-
-    match dialog.show_save_single_file() {
-        Ok(Some(path)) => {
-            info!(target: "ui.drive.picker", path = ?path, "Save location selected");
-            set_last_directory(&path);
-            PickerResult::Selected(vec![path])
-        }
-        Ok(None) => {
-            debug!(target: "ui.drive.picker", "Save picker cancelled");
-            PickerResult::Cancelled
-        }
-        Err(e) => {
-            warn!(target: "ui.drive.picker", error = %e, "Save picker error");
-            PickerResult::Error(e.to_string())
-        }
-    }
-}
-
-/// Show an error message dialog.
-#[allow(dead_code)]
-pub fn show_error_dialog(title: &str, message: &str) {
-    let _ = MessageDialog::new()
-        .set_title(title)
-        .set_text(message)
-        .set_type(MessageType::Error)
-        .show_alert();
-}
-
-/// Show an info message dialog.
-#[allow(dead_code)]
-pub fn show_info_dialog(title: &str, message: &str) {
-    let _ = MessageDialog::new()
-        .set_title(title)
-        .set_text(message)
-        .set_type(MessageType::Info)
-        .show_alert();
-}
-
-/// Show a confirmation dialog. Returns true if confirmed.
-#[allow(dead_code)]
-pub fn show_confirm_dialog(title: &str, message: &str) -> bool {
-    MessageDialog::new()
-        .set_title(title)
-        .set_text(message)
-        .set_type(MessageType::Warning)
-        .show_confirm()
-        .unwrap_or(false)
-}
 
 /// File picker button component props.
 #[derive(Props, Clone, PartialEq)]