Make the hyperliquid script import from csv#5176
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughScript refactored to accept a CSV path, parse ChangesCSV-driven Hyperliquid Mapping Seeding
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/seed_hyperliquid_source_slug_mappings.exs`:
- Around line 64-65: The pattern match that returns [{String.trim(coin),
String.trim(slug)}] allows empty coin or slug (e.g., ",bitcoin" or "btc,");
update the clause that matches [coin, slug | _] to trim both values and reject
them if either is blank by raising the same error (using idx and line) instead
of returning a mapping; reference the variables coin, slug, the call
String.trim, and the raise expression so you verify non-empty trimmed_coin and
trimmed_slug before producing the tuple.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 85277ff1-6f99-4e18-9f9d-635c2b9f7f4d
📒 Files selected for processing (1)
scripts/seed_hyperliquid_source_slug_mappings.exs
93f9912 to
80f6a79
Compare
Changes
Ticket
Checklist:
Summary by CodeRabbit