fix: pass --append flag through to batch creator update (#383)

raushan728 · web-flow · commit c26075a65f7f · 2026-04-17T16:37:59.000-08:00
* test: document that update creators-all --append flag is ignored

* fix: pass --append flag through to batch creator update
diff --git a/src/burn/burn_asset.rs b/src/burn/burn_asset.rs
@@ -82,6 +82,7 @@ pub async fn burn_asset_all(args: BurnAssetAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::None,
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/burn/burn_legacy.rs b/src/burn/burn_legacy.rs
@@ -140,6 +140,7 @@ pub async fn burn_all(args: BurnAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::None,
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
@@ -243,6 +244,7 @@ pub async fn burn_print_all(args: BurnPrintAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::Single(args.master_mint),
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/cache/mod.rs b/src/cache/mod.rs
@@ -110,6 +110,7 @@ pub struct BatchActionArgs {
     pub mint_list: Option<Vec<String>>,
     pub cache_file: Option<String>,
     pub new_value: NewValue,
+    pub should_append: bool,
     pub rate_limit: usize,
     pub retries: u8,
     pub priority: Priority,
@@ -121,6 +122,7 @@ pub struct RunActionArgs {
     pub payer: Arc<Option<Keypair>>,
     pub mint_account: String,
     pub new_value: String,
+    pub should_append: bool,
     pub priority: Priority,
 }
 
@@ -345,6 +347,7 @@ pub trait Action {
                         payer: payer.clone(),
                         mint_account: mint_address,
                         new_value: new_value.to_string(),
+                        should_append: args.should_append,
                         priority: args.priority.clone(),
                     });
 
diff --git a/src/unverify/creator.rs b/src/unverify/creator.rs
@@ -103,6 +103,7 @@ pub async fn unverify_creator_all(args: UnverifyCreatorAllArgs) -> AnyResult<()>
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::None,
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/creator.rs b/src/update/creator.rs
@@ -101,6 +101,7 @@ pub async fn update_creator_all(args: UpdateCreatorAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::Single(args.new_creators),
+        should_append: args.should_append,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
@@ -122,7 +123,7 @@ impl Action for UpdateCreatorAll {
             keypair: args.keypair,
             mint_account: args.mint_account,
             new_creators: args.new_value,
-            should_append: false,
+            should_append: args.should_append,
             priority: args.priority,
         })
         .await
diff --git a/src/update/data.rs b/src/update/data.rs
@@ -162,6 +162,7 @@ pub async fn update_data_all(args: UpdateDataAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::List(mint_values),
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/immutable.rs b/src/update/immutable.rs
@@ -81,6 +81,7 @@ pub async fn set_immutable_all(args: SetImmutableAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::None,
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/primary_sale_happened.rs b/src/update/primary_sale_happened.rs
@@ -81,6 +81,7 @@ pub async fn set_primary_sale_happened_all(args: SetPrimarySaleHappenedAllArgs)
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::None,
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/rule_set.rs b/src/update/rule_set.rs
@@ -131,6 +131,7 @@ pub async fn update_rule_set_all(args: UpdateRuleSetAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::Single(args.new_rule_set),
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
@@ -174,6 +175,7 @@ pub async fn clear_rule_set_all(args: ClearRuleSetAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::None,
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/seller_fee_basis_points.rs b/src/update/seller_fee_basis_points.rs
@@ -103,6 +103,7 @@ pub async fn update_sfbp_all(args: UpdateSellerFeeBasisPointsAllArgs) -> AnyResu
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::Single(args.new_sfbp.to_string()),
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/symbol.rs b/src/update/symbol.rs
@@ -93,6 +93,7 @@ pub async fn update_symbol_all(args: UpdateSymbolAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::Single(args.new_symbol),
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/token_standard.rs b/src/update/token_standard.rs
@@ -98,6 +98,7 @@ pub async fn set_token_standard_all(args: SetTokenStandardAllArgs) -> AnyResult<
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::None,
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/update_authority.rs b/src/update/update_authority.rs
@@ -93,6 +93,7 @@ pub async fn set_update_authority_all(args: SetUpdateAuthorityAllArgs) -> AnyRes
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::Single(args.new_authority),
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/update/uri.rs b/src/update/uri.rs
@@ -120,6 +120,7 @@ pub async fn update_uri_all(args: UpdateUriAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::List(mint_values),
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/src/verify/creator.rs b/src/verify/creator.rs
@@ -103,6 +103,7 @@ pub async fn verify_creator_all(args: VerifyCreatorAllArgs) -> AnyResult<()> {
         mint_list,
         cache_file: args.cache_file,
         new_value: NewValue::None,
+        should_append: false,
         rate_limit: args.rate_limit,
         retries: args.retries,
         priority: args.priority,
diff --git a/tests/update_tests.rs b/tests/update_tests.rs
@@ -271,3 +271,54 @@ fn test_update_data() -> Result<()> {
 
     Ok(())
 }
+
+// ---------------------------------------------------------------------------
+// Test 6: Mint an NFT and execute update creators-all with --append flag
+// ---------------------------------------------------------------------------
+#[test]
+#[ignore = "requires solana-test-validator (run with --ignored)"]
+fn test_update_creators_all_append() -> Result<()> {
+    // Initialize Context
+    let mut ctx = TestContext::new()?;
+    let temp_dir = ctx.create_temp_dir("update-creators-all-append");
+
+    // Mint test NFT (Assigns default creator A)
+    let mint = mint_test_nft(&ctx, &temp_dir)?;
+
+    // Write mint address to a temp list file
+    let mint_list_file = temp_dir.join("append_test_mints.json");
+    let mut file = std::fs::File::create(&mint_list_file)?;
+    file.write_all(serde_json::to_string(&vec![&mint])?.as_bytes())?;
+    let mint_list_file_str = mint_list_file.to_string_lossy().to_string();
+
+    // Generate a new keypair for creator B
+    let new_creator = Keypair::new();
+    let new_creator_pubkey = new_creator.pubkey().to_string();
+    let new_creators_arg = format!("{}:0:false", new_creator_pubkey);
+
+    // Run update creators-all --append with creator B
+    let output = ctx.run_metaboss(&[
+        "update",
+        "creators-all",
+        "-k",
+        &ctx.keypair_path,
+        "-L",
+        &mint_list_file_str,
+        "--new-creators",
+        &new_creators_arg,
+        "--append",
+    ]);
+    assert_success(&output);
+
+    // Decode and assert creators
+    let metadata = decode_onchain_metadata(&ctx, &mint)?;
+    let creators = metadata
+        .creators
+        .expect("creators should be present after update");
+
+    // The --append flag is respected and creator B is appended to creator A,
+    // so length is 2.
+    assert_eq!(creators.len(), 2, "--append works, both creators present");
+
+    Ok(())
+}
