Fix bug in SkewPolynomialRing when twisting morphism is trivial #40697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit d0a839e; changes) is ready! 🎉 |
kryzar
reviewed
Sep 4, 2025
Contributor
|
I've searched for |
Contributor
Author
|
I don't know but it is similar in many (all?) PR. So, I think we do have to care about this. |
kryzar
approved these changes
Sep 5, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 7, 2025
sagemathgh-40697: Fix bug in SkewPolynomialRing when twisting morphism is trivial When a skew polynomial ring is created with a trivial twisting morphism (with option `polcast=False`), the attribute `_morphism` is set to `None`, which makes several methods produce an error. This PR fixes this bug. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40697 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 11, 2025
sagemathgh-40697: Fix bug in SkewPolynomialRing when twisting morphism is trivial When a skew polynomial ring is created with a trivial twisting morphism (with option `polcast=False`), the attribute `_morphism` is set to `None`, which makes several methods produce an error. This PR fixes this bug. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40697 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
Contributor
Author
|
I don't understand if this PR is planned to be merged or not but, in any case, I give back the positive review. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 16, 2025
sagemathgh-40697: Fix bug in SkewPolynomialRing when twisting morphism is trivial When a skew polynomial ring is created with a trivial twisting morphism (with option `polcast=False`), the attribute `_morphism` is set to `None`, which makes several methods produce an error. This PR fixes this bug. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40697 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a skew polynomial ring is created with a trivial twisting morphism (with option
polcast=False), the attribute_morphismis set toNone, which makes several methods produce an error.This PR fixes this bug.
📝 Checklist