-
-
Notifications
You must be signed in to change notification settings - Fork 712
Add absolute_degree method to finite fields
#40427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7bd2c13 to
13bde43
Compare
|
To be fair, number fields have Maybe we could have something similar here. |
|
I agree that this would be the best solution. The thing is that, to have something similar to number fields, I believe we would either need to implement extensions of finite fields, which would require much work, or to do a breaking change. Currently, SageMath uses the If we rename |
|
Not necessarily, we could just add |
is_prime_field method to PolynomialQuotientRing_genericabsolute_degree method to finite fields
|
Sorry for the delay, I'm on holiday and will be slow to answer in the next weeks (but I will always reply eventually). @user202729 I liked your idea to add |
|
Failing doctests, please wait until I can fix this. |
4fc1142 to
018f1d0
Compare
|
Ready for review! |
|
Documentation preview for this PR (built with commit b69ee84; changes) is ready! 🎉 |
|
I... guess I forgot this. Looks reasonable. I don't like the ( |
|
Thank you! |
sagemathgh-40427: Add `absolute_degree` method to finite fields This PR adds an `absolute_degree` method to various finite fields class. This is done in order to fix `is_prime_field`. The reason is explained in my bug report sagemath#40426. In the same time, I also updated documentation is various parts of the code. Fixes sagemath#40426. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40427 Reported by: Rubén Muñoz--Bertrand Reviewer(s): Frédéric Chapoton, Rubén Muñoz--Bertrand
sagemathgh-40427: Add `absolute_degree` method to finite fields This PR adds an `absolute_degree` method to various finite fields class. This is done in order to fix `is_prime_field`. The reason is explained in my bug report sagemath#40426. In the same time, I also updated documentation is various parts of the code. Fixes sagemath#40426. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40427 Reported by: Rubén Muñoz--Bertrand Reviewer(s): Frédéric Chapoton, Rubén Muñoz--Bertrand
This PR adds an
absolute_degreemethod to various finite fields class. This is done in order to fixis_prime_field. The reason is explained in my bug report #40426.In the same time, I also updated documentation is various parts of the code.
Fixes #40426.
📝 Checklist