cleanup in number_field.py #40080
Merged
cleanup in number_field.py #40080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit da4ee66; changes) is ready! 🎉 |
edgarcosta
approved these changes
May 14, 2025
Member
|
merge conflict, please fix |
fchapoton
force-pushed
the
clenup_number_field
branch
from
da4ee66 to
9ca4f92
Compare
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 24, 2025
sagemathgh-40080: cleanup in number_field.py small pep8 cleanup, some typing annotation alos getting rid of the old `_cache_an_element` attribute ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40080 Reported by: Frédéric Chapoton Reviewer(s): Edgar Costa
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 26, 2025
sagemathgh-40080: cleanup in number_field.py small pep8 cleanup, some typing annotation alos getting rid of the old `_cache_an_element` attribute ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40080 Reported by: Frédéric Chapoton Reviewer(s): Edgar Costa
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-40080: cleanup in number_field.py small pep8 cleanup, some typing annotation alos getting rid of the old `_cache_an_element` attribute ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40080 Reported by: Frédéric Chapoton Reviewer(s): Edgar Costa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small pep8 cleanup, some typing annotation
alos getting rid of the old
_cache_an_elementattribute📝 Checklist
⌛ Dependencies