introduce the bubble and shuffle lattices #40037

fchapoton · 2025-05-02T09:00:32Z

Adding two new posets in our catalog : The Bubble lattices and the Shuffle lattices.

📝 Checklist

The title is concise and informative.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation and checked the documentation preview.

github-actions · 2025-05-02T11:36:11Z

Documentation preview for this PR (built with commit fa8d02f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

fchapoton · 2025-05-11T18:09:25Z

@tscrim, would you please have time for this one ?

tscrim

Two additional general comments:

I would call the file bubble_shuffle.py.

I would provide at least a sketch of the definitions of the posets in the construction functions.

src/doc/en/reference/references/index.rst

src/sage/combinat/posets/bubble_and_shuffle.py

tscrim

Thank you. Just now the annoying conftest.py deletion... (We really should complain on sage-devel about that.) Once addressed, then you can set a positive review.

fchapoton · 2025-05-13T13:15:56Z

I have not yet added a mathematical definition of the posets.

tscrim · 2025-05-13T13:17:20Z

Ah, right, yes, please also add that.

tscrim

Thank you. Although I think it would be better to have the definitions local to each function so it can be read by posets.BubblePoset?.

src/sage/combinat/posets/bubble_shuffle.py

dimpase · 2025-05-15T07:12:04Z

Thank you. Just now the annoying conftest.py deletion... (We really should complain on sage-devel about that.) Once addressed, then you can set a positive review.

what exactly is the problem of conftest.py deletion? if you don't interrupt configure script manually or by breaking some autoconf macro, it gets restored just fine.

Co-authored-by: Travis Scrimshaw <[email protected]>

fchapoton · 2025-05-15T09:14:04Z

Every time I compile using make build, the conftest.py is not restored. On several ubuntu machines, where I am using a source install done many years ago.

dimpase · 2025-05-15T23:12:11Z

The whole idea that make build can invoke ./bootstrap and ./configure is silly --- that's not how GNU toolchain is designed to be used. I was always saying that make build must not touch ./configure, because one makes a configured build! If you want me to fix it, I can remove the ability of make build to mess around with ./configure, as this is the right fix IMHO.

fchapoton · 2025-05-19T07:49:30Z

@tscrim : I have moved the doc as suggested, I think. Do you have any other suggestion or comment ?

tscrim

Thank you. LGTM.

tscrim · 2025-05-19T11:25:56Z

@dimpase It would be appreciated if something could be done so this file is repeatedly deleted when building/upgrading Sage. It’s a hassle.

dimpase · 2025-05-20T21:42:25Z

which file?

tscrim · 2025-05-21T00:35:19Z

which file?

conftest.py.

dimpase · 2025-05-21T01:02:28Z

which file?

conftest.py.

Sorry, I explained above how to avoid deleting this file.
Otherwise, feel free to trace the biting you bug (or feature) in Sage's self-modifying bunch of config files and makefiles you prefer to the normal way of operating the GNU toolchain.

tscrim · 2025-05-21T01:09:59Z

Every time I compile using make build, the conftest.py is not restored. On several ubuntu machines, where I am using a source install done many years ago.

@dimpase I clearly am having this as well. Nothing is breaking for us during the build and it is not getting restored. It's also appeared for many other contributors' PRs.

dimpase · 2025-05-21T01:26:03Z

If you change something that triggers a run of configure, such as a package update, and you don't run ./configure before hitting make build, then ./configure in our wonderful build system is invoked automatically, and it does modify makefiles and what not.

It's above my pay grade to search for bugs in recursively self-modifying systems like this.

I have been talking for years arguing that sage the distro is a bloatware, and needs to be simplified and streamlined - hearing in response mostly that it just works, so why bother.

tscrim · 2025-05-21T05:52:02Z

I run ./configure && make build when upgrading. Well, anyways, none of us have the ability to fix it...

dimpase · 2025-05-21T06:33:13Z

On Tue, May 20, 2025 at 10:52:24PM -0700, Travis Scrimshaw wrote: tscrim left a comment (sagemath/sage#40037) I run `./configure && make build` when upgrading. Well, anyways, none of us have the ability to fix it...

it might help if you post the install.log of such a run which resulted in lost conftest.py (needless to say, making sure it's present before this is run). First of all, it could be that the latter is not restored after ./configure is run. (maybe some weird shell quirks or permissions fun on macOS, no idea)

tscrim · 2025-05-21T07:30:45Z

I will do that to sage-devel soon. I usually forget about it because I reset it and just continue on my way each time I upgrade.

dimpase · 2025-05-21T19:41:06Z

I run ./configure && make build when upgrading. Well, anyways, none of us have the ability to fix it...

For many upgrades you need to run ./bootstrap first. So this could be the culprit - make finds out you need to run it, it in turn triggers the run of ./configure, and the self-modifying hell breaks loose

vbraun · 2025-05-21T22:18:05Z

! Undefined control sequence.
l.8176 ...s of Galois for elliptic curves over} \(\Q
                                                  \) (and an appendix with J...

src/doc/en/reference/references/index.rst

Co-authored-by: Travis Scrimshaw <[email protected]>

tscrim · 2025-05-26T00:50:52Z

Thanks. That fixes it.

sagemathgh-40037: introduce the bubble and shuffle lattices Adding two new posets in our catalog : The Bubble lattices and the Shuffle lattices. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40037 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw

fchapoton added the c: combinatorics label May 2, 2025

github-actions bot added the s: needs review label May 2, 2025

tscrim requested changes May 11, 2025

View reviewed changes

tscrim approved these changes May 13, 2025

View reviewed changes

adding the bubble and shuffle posets

4b2ded4

fchapoton force-pushed the bubble_and_shuffle branch from 2792b47 to 4b2ded4 Compare May 13, 2025 13:15

adding a short description of the partial orders

e29897a

tscrim requested changes May 15, 2025

View reviewed changes

src/sage/combinat/posets/bubble_shuffle.py Outdated Show resolved Hide resolved

fchapoton and others added 2 commits May 15, 2025 11:05

Update src/sage/combinat/posets/bubble_shuffle.py

d49bfbc

Co-authored-by: Travis Scrimshaw <[email protected]>

moving the doc around

9b05ab0

tscrim approved these changes May 19, 2025

View reviewed changes

tscrim added s: positive review and removed s: needs review labels May 19, 2025

vbraun added the s: needs work label May 21, 2025

tscrim reviewed May 22, 2025

View reviewed changes

src/doc/en/reference/references/index.rst Outdated Show resolved Hide resolved

Update src/doc/en/reference/references/index.rst

a373454

Co-authored-by: Travis Scrimshaw <[email protected]>

fchapoton removed the s: positive review label May 22, 2025

github-actions bot added s: needs review and removed s: needs work labels May 22, 2025

tscrim added s: positive review and removed s: needs review labels May 26, 2025

vbraun merged commit a034f8d into sagemath:develop Jun 1, 2025
14 of 24 checks passed

fchapoton deleted the bubble_and_shuffle branch June 2, 2025 15:24

Uh oh!

introduce the bubble and shuffle lattices #40037

introduce the bubble and shuffle lattices #40037

Uh oh!

Conversation

fchapoton commented May 2, 2025

📝 Checklist

Uh oh!

github-actions bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fchapoton commented May 11, 2025

Uh oh!

tscrim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tscrim left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fchapoton commented May 13, 2025

Uh oh!

tscrim commented May 13, 2025

Uh oh!

tscrim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dimpase commented May 15, 2025

Uh oh!

fchapoton commented May 15, 2025

Uh oh!

dimpase commented May 15, 2025

Uh oh!

fchapoton commented May 19, 2025

Uh oh!

tscrim left a comment

Choose a reason for hiding this comment

Uh oh!

tscrim commented May 19, 2025

Uh oh!

dimpase commented May 20, 2025

Uh oh!

tscrim commented May 21, 2025

Uh oh!

dimpase commented May 21, 2025

Uh oh!

tscrim commented May 21, 2025

Uh oh!

dimpase commented May 21, 2025

Uh oh!

tscrim commented May 21, 2025

Uh oh!

dimpase commented May 21, 2025 via email

Uh oh!

tscrim commented May 21, 2025

Uh oh!

dimpase commented May 21, 2025

Uh oh!

vbraun commented May 21, 2025

Uh oh!

Uh oh!

tscrim commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented May 2, 2025 •

edited

Loading

tscrim left a comment •

edited

Loading

tscrim commented May 26, 2025 •

edited

Loading