Overwrote the method is_biconnected() for MatchingCoveredGraph
#39657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 177e7d5; changes) is ready! 🎉 |
Contributor
|
If this PR is only for |
Contributor
Author
|
HI, |
Contributor
|
I think other methods could be done in future PRs. |
Contributor
Author
|
Thank you. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 27, 2025
sagemathgh-39657: Overwrote methods concerning connectivity in a matching covered graph <!-- ^ Please provide a concise and informative title. --> The objective of this PR is to overwrite the methods pertaining to connectivity in a matching covered graph. <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> More specifically, this PR aims to overwrite the following methods: - [x] `is_biconnected()` | Check whether the (matching covered) graph is biconnected. - [ ] `is_connected()` | Check whether the (matching covered) graph is connected. ### 📌 Todo - [ ] Add the list of other relevant methods to overwrite (so that the computation time is asymptotically shorter). <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38216. Please note that this issue fixes a small part of the mentioned issue. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Nothing as of now. <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc: @dcoudert. URL: sagemath#39657 Reported by: Janmenjaya Panda Reviewer(s): David Coudert
janmenjayap
changed the title
is_biconnected() for MatchingCoveredGraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to overwrite the methods pertaining to connectivity in a matching covered graph.
More specifically, this PR aims to overwrite the following methods:
is_biconnected()| Check whether the (matching covered) graph is biconnected.Fixes #38216.
Please note that this issue fixes a small part of the mentioned issue.
📝 Checklist
⌛ Dependencies
Nothing as of now.
cc: @dcoudert.