Add conversion dictionaries to trig.py #38853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add conversion of tan, cot, sec and csc functions to trig.py
|
Documentation preview for this PR (built with commit 05d89d7; changes) is ready! 🎉 |
Collaborator
|
Check Lint. |
Collaborator
|
Otherwise lgtm. |
Trailing space removed to pass code style check by pycodestyle-minimal.
kwankyu
added
s: positive review
c: interfaces
c: calculus
and removed
s: needs review
labels
Contributor
Author
|
I am sorry, I am not able to figure out where is the problem with the failing build & test... |
Collaborator
|
"Build & Test using Conda"? It is not related with this PR. We can ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conversions of
tan,cot,sec, andcscfunctions totrig.pyto allow conversions from Mathematica, FriCAS, Maxima, Giac, and SymPy. The conversion dictionaries were present in other trigonometric functions but (quite surprisingly for me) absent in the above-mentioned four cases.Fixes #38852.
📝 Checklist
⌛ Dependencies
No additional dependency.