Skip to content

Conversation

@fchapoton
Copy link
Contributor

this is about fixing the warning

E302 expected 2 blank lines, found 1

in the manifolds and geometry folders.

Purely scripted using autopep8

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions
Copy link

Documentation preview for this PR (built with commit 1f8dae9; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Member

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 17, 2024
this is about fixing the warning

E302 expected 2 blank lines, found 1

in the `manifolds` and `geometry` folders.

Purely scripted using `autopep8`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

URL: sagemath#38816
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 18, 2024
sagemathgh-38816: fix all pep E302 in manifolds and geometry
    
this is about fixing the warning

E302 expected 2 blank lines, found 1

in the `manifolds` and `geometry` folders.

Purely scripted using `autopep8`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38816
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 20, 2024
sagemathgh-38816: fix all pep E302 in manifolds and geometry
    
this is about fixing the warning

E302 expected 2 blank lines, found 1

in the `manifolds` and `geometry` folders.

Purely scripted using `autopep8`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38816
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 23, 2024
sagemathgh-38816: fix all pep E302 in manifolds and geometry
    
this is about fixing the warning

E302 expected 2 blank lines, found 1

in the `manifolds` and `geometry` folders.

Purely scripted using `autopep8`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38816
Reported by: Frédéric Chapoton
Reviewer(s): Vincent Macri
@vbraun vbraun merged commit e028ecc into sagemath:develop Oct 26, 2024
16 of 17 checks passed
@fchapoton fchapoton deleted the pep_E302_manifolds_geometry branch October 26, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants