some pep8 fixes in sage/all.py #38696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit cbd9c2d; changes) is ready! 🎉 |
kwankyu
reviewed
Sep 23, 2024
| # Debugging for Singular, see trac #10903 | ||
| # from sage.libs.singular.ring import poison_currRing | ||
| # sys.settrace(poison_currRing) | ||
|
|
Collaborator
There was a problem hiding this comment.
The first line is a comment to the following commented code lines.
Collaborator
There was a problem hiding this comment.
# # Debugging for Singular, see Issue #10903
?
Collaborator
There was a problem hiding this comment.
it is capitalized "Issue"... How about "##" instead of "####"?
Contributor
Author
There was a problem hiding this comment.
come on, please spare my time and yours.
kwankyu
approved these changes
Sep 23, 2024
Collaborator
kwankyu
left a comment
kwankyu
left a comment
There was a problem hiding this comment.
LGTM (except the issue :-)
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2024
sagemathgh-38696: some pep8 fixes in sage/all.py This is fixing E272 multiple spaces before keyword in all.py ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38696 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing
E272 multiple spaces before keyword
in all.py
📝 Checklist