Set partition to disjoint set #38693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 0761846; changes) is ready! 🎉 |
dcoudert
reviewed
Sep 22, 2024
| {{0}, {1}, {2}, {3}, {4}} | ||
| sage: DisjointSet(SP) == DisjointSet(5) | ||
| True | ||
src/sage/sets/disjoint_set.pyx
Outdated
| sage: DisjointSet(['yi', 45, 'cheval']) | ||
| {{'cheval'}, {'yi'}, {45}} | ||
| From a set partition:: |
Contributor
There was a problem hiding this comment.
you could add a reference to the issue or the PR using (see :issue:`12345`)
Contributor
Author
|
Fixed. I also forgot that this issue handles #38416 by providing the alternative solution. |
dcoudert
approved these changes
Sep 23, 2024
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
go back to positive review after rebase
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2024
sagemathgh-38693: Set partition to disjoint set <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This issue fixes the bug in sagemath#38415 . It uses the base of `SetPartition` to allow a `DisjointSet` to be created in a nice way. This also solves issue sagemath#38416 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> sagemath#38415 , sagemath#38416 URL: sagemath#38693 Reported by: Aram Dermenjian Reviewer(s): David Coudert
This was referenced Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue fixes the bug in #38415 . It uses the base of
SetPartitionto allow aDisjointSetto be created in a nice way. This also solves issue #38416📝 Checklist
⌛ Dependencies
#38415 , #38416