switch from genbg to genbgL in nauty_genbg to generate larger bipartite graphs.
#38621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Documentation preview for this PR (built with commit 0dc4a54; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
sagemathgh-38621: switch from `genbg` to `genbgL` in `nauty_genbg` to generate larger bipartite graphs. Fixes sagemath#38618. `genbg` was limited to bipartite graphs with up to 32 vertices. Using `genbgL`, we can go to 64 vertices. Note that in the doctests, we use the form `...genbg...` as currently lines starting with `>A` contain `genbgL` while lines starting with `>E` contain `genbg`. using this formulation, we are on the safe side. On the way, we fix the documentation of `digraphs.tournaments_nauty()`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38621 Reported by: David Coudert Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
sagemathgh-38621: switch from `genbg` to `genbgL` in `nauty_genbg` to generate larger bipartite graphs. Fixes sagemath#38618. `genbg` was limited to bipartite graphs with up to 32 vertices. Using `genbgL`, we can go to 64 vertices. Note that in the doctests, we use the form `...genbg...` as currently lines starting with `>A` contain `genbgL` while lines starting with `>E` contain `genbg`. using this formulation, we are on the safe side. On the way, we fix the documentation of `digraphs.tournaments_nauty()`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38621 Reported by: David Coudert Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 10, 2024
sagemathgh-38621: switch from `genbg` to `genbgL` in `nauty_genbg` to generate larger bipartite graphs. Fixes sagemath#38618. `genbg` was limited to bipartite graphs with up to 32 vertices. Using `genbgL`, we can go to 64 vertices. Note that in the doctests, we use the form `...genbg...` as currently lines starting with `>A` contain `genbgL` while lines starting with `>E` contain `genbg`. using this formulation, we are on the safe side. On the way, we fix the documentation of `digraphs.tournaments_nauty()`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38621 Reported by: David Coudert Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 12, 2024
sagemathgh-38621: switch from `genbg` to `genbgL` in `nauty_genbg` to generate larger bipartite graphs. Fixes sagemath#38618. `genbg` was limited to bipartite graphs with up to 32 vertices. Using `genbgL`, we can go to 64 vertices. Note that in the doctests, we use the form `...genbg...` as currently lines starting with `>A` contain `genbgL` while lines starting with `>E` contain `genbg`. using this formulation, we are on the safe side. On the way, we fix the documentation of `digraphs.tournaments_nauty()`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38621 Reported by: David Coudert Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38618.
genbgwas limited to bipartite graphs with up to 32 vertices. UsinggenbgL, we can go to 64 vertices.Note that in the doctests, we use the form
...genbg...as currently lines starting with>AcontaingenbgLwhile lines starting with>Econtaingenbg. using this formulation, we are on the safe side.On the way, we fix the documentation of
digraphs.tournaments_nauty().📝 Checklist
⌛ Dependencies