Skip to content

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 17, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Jun 17, 2024

Documentation preview for this PR (built with commit bd9d1a3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 17, 2024

Unfortunately the annotations don't work because each line is prefixed by Docker buildx's decorations.

Example: https://github.com/sagemath/sage/actions/runs/9542020402/job/26296119606#step:13:680

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 19, 2024

Unfortunately the annotations don't work because each line is prefixed by Docker buildx's decorations

Fixed? Can I see the changed behavior somewhere?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2024

Not fixed, not fixable.
What I hoped to do there regarding annotations will have to be done in a different way, by having the Docker build succeed even when there is a build error, and then retrieving the logs from the container and printing them out, similar to what is done in CI Linux.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2024

For this PR, I have reduced the scope to just print out the log without truncating. This was good enough to debug #38224.

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 19, 2024

OK.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2024

Thanks!

@vbraun vbraun merged commit 95c5841 into sagemath:develop Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants