Skip to content

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jan 21, 2024

There's no need to re-run configure if only template files such as build/make/Makefile.in (see AC_CONFIG_FILES in configure.ac) change: It suffices to run config.status in this case.

Fixes #32119

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 8, 2024

Thank you!

@github-actions
Copy link

github-actions bot commented Mar 8, 2024

Documentation preview for this PR (built with commit 663c222; changes) is ready! 🎉

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 8, 2024

I wonder if the failed test in B&T is related...

Not related.

@vbraun vbraun merged commit ba8393e into sagemath:develop Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Makefile: If build/make/Makefile.in changes, only run ./config.status, not ... --recheck

3 participants