Skip to content

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Aug 19, 2023

Likewise for the module providing the parent class.

Also replace an import that is more specific than necessary, which helps for modularization.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert
Copy link
Contributor

You could do the same in sage/rings/finite_rings/element_givaro.pyx.

@github-actions
Copy link

Documentation preview for this PR (built with commit c0bad32; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 28, 2023

Thank you!

@vbraun vbraun merged commit 22446cb into sagemath:develop Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants