sage.{matrix,modules,probability,stats,quadratic_forms,tensor}: Update # needs, modularization fixes
#36070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 13, 2023 09:22
…absolute cannot be imported
added 7 commits
August 13, 2023 10:25
…ts,quadratic_forms,tensor}
dcoudert
suggested changes
Aug 15, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
I did my best too review this giant PR but I have certainly missed some details. There are way too many different kinds of improvements and the PR is way too big. Please do smaller PR that are easier to carefully review.
| sage: get_matrix_class(ZZ, 3, 3, False, 'flint') | ||
| <class 'sage.matrix.matrix_integer_dense.Matrix_integer_dense'> | ||
| sage: get_matrix_class(ZZ, 3, 3, False, 'gap') | ||
| sage: get_matrix_class(ZZ, 3, 3, False, 'gap') # needs sage.modules |
| - ``parent`` -- the desired size of the square matrix. | ||
| - ``eigenvalues`` - the list of desired eigenvalues (default=None). | ||
| - ``eigenvalues`` -- the list of desired eigenvalues (default=None). |
added 5 commits
August 15, 2023 22:05
dcoudert
reviewed
Aug 17, 2023
| sage: b = numpy.array(a); b | ||
| array([[ 0, 1, 2, 3], | ||
| [ 4, 5, 6, 7], | ||
| [ 8, 9, 10, 11]]) |
Contributor
There was a problem hiding this comment.
When I test this file, I have the following warning for this block. I don't understand why. Can we avoid this warning ?
sage -t --long --warn-long 20.5 --random-seed=138094706570993025836638675226273367820 src/sage/matrix/matrix1.pyx
**********************************************************************
File "src/sage/matrix/matrix1.pyx", line 729, in sage.matrix.matrix1.Matrix.numpy
Warning: Variable 'b' referenced here was set only in doctest marked '# needs numpy'
b.shape
Contributor
Author
There was a problem hiding this comment.
Interesting. My guess is that this is caused by the # 32-bit / # 64-bit in this doctest. I'll investigate.
Contributor
There was a problem hiding this comment.
OK. So I conclude the review.
Contributor
|
Other cosmetic changes can be done in future PRs. |
Contributor
Author
|
Thanks very much for the patient review. I've just pushed the changes for your comments that I had already marked as resolved |
dcoudert
approved these changes
Aug 17, 2023
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
I agree with these extra commits.
Contributor
Author
|
Thanks! |
Member
|
documentation doesn't build |
|
Documentation preview for this PR (built with commit 4c4d62f; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 23, 2023
sagemathgh-36070: `sage.{matrix,modules,probability,stats,quadratic_forms,tensor}`: Update `# needs`, modularization fixes <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Also defining new features `sage.libs.linbox`, `sage.libs.m4ri`. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - Part of: sagemath#29705 - Cherry-picked from: sagemath#35095 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36070 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also defining new features
sage.libs.linbox,sage.libs.m4ri.📝 Checklist
⌛ Dependencies