Skip to content

Commit c49562e

Browse files
tornariatornaria
committed
gap: fix doctests for gap 4.13
In gap 4.13 there are some improvements, e.g. converting fp groups to permutation groups, computing abelianization of fp groups, which lead to different generators. This commit fixes doctests so they pass using gap 4.13.
1 parent 744939e commit c49562e

File tree

4 files changed

+33
-35
lines changed

4 files changed

+33
-35
lines changed

‎src/sage/algebras/fusion_rings/fusion_double.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ class FusionDouble(CombinatorialFreeModule):
132132
sage: G = SmallPermutationGroup(16,9)
133133
sage: F = FusionDouble(G, prefix="b",inject_variables=True)
134134
sage: b13^2 # long time (4s)
135-
b0 + b2 + b4 + b15 + b16 + b17 + b18 + b24 + b26 + b27
135+
b0 + b3 + b4
136136
137137
"""
138138
@staticmethod

‎src/sage/categories/simplicial_sets.py‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -593,9 +593,9 @@ def _canonical_twisting_operator(self):
593593
sage: X = simplicial_sets.Torus()
594594
sage: d = X._canonical_twisting_operator()
595595
sage: d
596-
{(s_0 v_0, sigma_1): f3, (sigma_1, s_0 v_0): f2*f3^-1, (sigma_1, sigma_1): f2}
596+
{(s_0 v_0, sigma_1): f2, (sigma_1, s_0 v_0): f1*f2^-1, (sigma_1, sigma_1): f1}
597597
sage: list(d.values())[0].parent()
598-
Multivariate Laurent Polynomial Ring in f2, f3 over Integer Ring
598+
Multivariate Laurent Polynomial Ring in f1, f2 over Integer Ring
599599
sage: Y = simplicial_sets.RealProjectiveSpace(2)
600600
sage: d2 = Y._canonical_twisting_operator()
601601
sage: d2
@@ -675,10 +675,10 @@ def twisted_chain_complex(self, twisting_operator=None, dimensions=None, augment
675675
sage: X = simplicial_sets.Torus()
676676
sage: C = X.twisted_chain_complex()
677677
sage: C.differential(1)
678-
[ f3 - 1 f2*f3^-1 - 1 f2 - 1]
678+
[ f2 - 1 f1*f2^-1 - 1 f1 - 1]
679679
sage: C.differential(2)
680-
[ 1 f2*f3^-1]
681-
[ f3 1]
680+
[ 1 f1*f2^-1]
681+
[ f2 1]
682682
[ -1 -1]
683683
sage: C.differential(3)
684684
[]
@@ -843,29 +843,29 @@ def twisted_homology(self, n, reduced=False):
843843
844844
sage: Y = simplicial_sets.Torus()
845845
sage: Y.twisted_homology(1)
846-
Quotient module by Submodule of Ambient free module of rank 5 over the integral domain Multivariate Polynomial Ring in f2, f2inv, f3, f3inv over Integer Ring
846+
Quotient module by Submodule of Ambient free module of rank 5 over the integral domain Multivariate Polynomial Ring in f1, f1inv, f2, f2inv over Integer Ring
847847
Generated by the rows of the matrix:
848848
[ 1 0 0 0 0]
849849
[ 0 1 0 0 0]
850850
[ 0 0 1 0 0]
851851
[ 0 0 0 1 0]
852852
[ 0 0 0 0 1]
853+
[f1*f1inv - 1 0 0 0 0]
854+
[ 0 f1*f1inv - 1 0 0 0]
855+
[ 0 0 f1*f1inv - 1 0 0]
856+
[ 0 0 0 f1*f1inv - 1 0]
857+
[ 0 0 0 0 f1*f1inv - 1]
853858
[f2*f2inv - 1 0 0 0 0]
854859
[ 0 f2*f2inv - 1 0 0 0]
855860
[ 0 0 f2*f2inv - 1 0 0]
856861
[ 0 0 0 f2*f2inv - 1 0]
857862
[ 0 0 0 0 f2*f2inv - 1]
858-
[f3*f3inv - 1 0 0 0 0]
859-
[ 0 f3*f3inv - 1 0 0 0]
860-
[ 0 0 f3*f3inv - 1 0 0]
861-
[ 0 0 0 f3*f3inv - 1 0]
862-
[ 0 0 0 0 f3*f3inv - 1]
863863
sage: Y.twisted_homology(2)
864-
Quotient module by Submodule of Ambient free module of rank 0 over the integral domain Multivariate Polynomial Ring in f2, f2inv, f3, f3inv over Integer Ring
864+
Quotient module by Submodule of Ambient free module of rank 0 over the integral domain Multivariate Polynomial Ring in f1, f1inv, f2, f2inv over Integer Ring
865865
Generated by the rows of the matrix:
866866
[]
867867
sage: Y.twisted_homology(1, reduced=True)
868-
Quotient module by Submodule of Ambient free module of rank 5 over the integral domain Multivariate Polynomial Ring in f2, f2inv, f3, f3inv over Integer Ring
868+
Quotient module by Submodule of Ambient free module of rank 5 over the integral domain Multivariate Polynomial Ring in f1, f1inv, f2, f2inv over Integer Ring
869869
Generated by the rows of the matrix:
870870
[1 0 0 0 0]
871871
[0 1 0 0 0]

‎src/sage/groups/finitely_presented.py‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1344,8 +1344,8 @@ def abelianization_map(self):
13441344
sage: H = G.quotient([g1^2, g2*g1*g2^(-1)*g1^(-1), g1*g3^(-2), g0^4])
13451345
sage: H.abelianization_map()
13461346
Group morphism:
1347-
From: Finitely presented group < g0, g1, g2, g3 | g1^2, g2*g1*g2^-1*g1^-1, g1*g3^-2, g0^4 >
1348-
To: Finitely presented group < f2, f3, f4 | f2^-1*f3^-1*f2*f3, f2^-1*f4^-1*f2*f4, f3^-1*f4^-1*f3*f4, f2^4, f3^4 >
1347+
From: Finitely presented group < g0, g1, g2, g3 | g1^2, g2*g1*g2^-1*g1^-1, g1*g3^-2, g0^4 >
1348+
To: Finitely presented group < f1, f2, f3 | f1^4, f2^-1*f1^-1*f2*f1, f2^4, f3^-1*f1^-1*f3*f1, f3^-1*f2^-1*f3*f2 >
13491349
sage: g = FreeGroup(0) / []
13501350
sage: g.abelianization_map()
13511351
Group endomorphism of Finitely presented group < | >
@@ -1394,10 +1394,10 @@ def abelianization_to_algebra(self, ring=QQ):
13941394
Defining g0, g1, g2, g3
13951395
sage: H = G.quotient([g1^2, g2*g1*g2^(-1)*g1^(-1), g1*g3^(-2), g0^4])
13961396
sage: H.abelianization_to_algebra()
1397-
(Finitely presented group < f2, f3, f4 | f2^-1*f3^-1*f2*f3, f2^-1*f4^-1*f2*f4,
1398-
f3^-1*f4^-1*f3*f4, f2^4, f3^4 >,
1399-
Multivariate Laurent Polynomial Ring in f2, f3, f4 over Rational Field,
1400-
[f2^4 - 1, f3^4 - 1], [f2^-1*f3^-2, f3^-2, f4, f3])
1397+
(Finitely presented group < f1, f2, f3 | f1^4, f2^-1*f1^-1*f2*f1, f2^4, f3^-1*f1^-1*f3*f1, f3^-1*f2^-1*f3*f2 >,
1398+
Multivariate Laurent Polynomial Ring in f1, f2, f3 over Rational Field,
1399+
[f1^4 - 1, f2^4 - 1],
1400+
[f1^3*f2^2, f2^2, f3, f2])
14011401
sage: g=FreeGroup(0) / []
14021402
sage: g.abelianization_to_algebra()
14031403
(Finitely presented group < | >, Rational Field, [], [])
@@ -1673,7 +1673,7 @@ def abelian_alexander_matrix(self, ring=QQ, simplified=True):
16731673
[]
16741674
sage: G = FreeGroup(3)/[(2, 1, 1), (1, 2, 2, 3, 3)]
16751675
sage: A, ideal = G.abelian_alexander_matrix(simplified=True); A
1676-
[-f3^2 - f3^4 - f3^6 f3^3 + f3^6]
1676+
[-f1^2 - f1^4 - f1^6 f1^3 + f1^6]
16771677
sage: g = FreeGroup(1) / []
16781678
sage: g.abelian_alexander_matrix()
16791679
([], [])
@@ -1773,11 +1773,11 @@ def characteristic_varieties(self, ring=QQ, matrix_ideal=None, groebner=False):
17731773
3: Ideal (1) of Multivariate Laurent Polynomial Ring in f1, f2 over Integer Ring}
17741774
sage: G = FreeGroup(2)/[(1,2,1,-2,-1,-2)]
17751775
sage: G.characteristic_varieties()
1776-
{0: Ideal (0) of Univariate Laurent Polynomial Ring in f2 over Rational Field,
1777-
1: Ideal (-1 + 2*f2 - 2*f2^2 + f2^3) of Univariate Laurent Polynomial Ring in f2 over Rational Field,
1778-
2: Ideal (1) of Univariate Laurent Polynomial Ring in f2 over Rational Field}
1776+
{0: Ideal (0) of Univariate Laurent Polynomial Ring in f1 over Rational Field,
1777+
1: Ideal (-1 + 2*f1 - 2*f1^2 + f1^3) of Univariate Laurent Polynomial Ring in f1 over Rational Field,
1778+
2: Ideal (1) of Univariate Laurent Polynomial Ring in f1 over Rational Field}
17791779
sage: G.characteristic_varieties(groebner=True)
1780-
{0: [0], 1: [-1 + f2, 1 - f2 + f2^2], 2: []}
1780+
{0: [0], 1: [-1 + f1, 1 - f1 + f1^2], 2: []}
17811781
sage: G = FreeGroup(2)/[3 * (1, ), 2 * (2, )]
17821782
sage: G.characteristic_varieties(groebner=True)
17831783
{0: [-1 + F1, 1 + F1, 1 - F1 + F1^2, 1 + F1 + F1^2], 1: [1 - F1 + F1^2], 2: []}

‎src/sage/groups/perm_gps/permgroup_named.py‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3451,16 +3451,14 @@ class SmallPermutationGroup(PermutationGroup_generic):
34513451
sage: G = SmallPermutationGroup(12,4); G
34523452
Group of order 12 and GAP Id 4 as a permutation group
34533453
sage: G.gens()
3454-
((1,2)(3,5)(4,10)(6,8)(7,12)(9,11),
3455-
(1,3)(2,5)(4,7)(6,9)(8,11)(10,12),
3456-
(1,4,8)(2,6,10)(3,7,11)(5,9,12))
3454+
((4,5), (1,2), (3,4,5))
34573455
sage: G.character_table() # needs sage.rings.number_field
34583456
[ 1 1 1 1 1 1]
3459-
[ 1 -1 -1 1 1 -1]
3457+
[ 1 -1 1 -1 1 -1]
34603458
[ 1 -1 1 1 -1 1]
3461-
[ 1 1 -1 1 -1 -1]
3462-
[ 2 0 -2 -1 0 1]
3463-
[ 2 0 2 -1 0 -1]
3459+
[ 1 1 1 -1 -1 -1]
3460+
[ 2 0 -1 -2 0 1]
3461+
[ 2 0 -1 2 0 -1]
34643462
sage: def numgps(n): return ZZ(libgap.NumberSmallGroups(n))
34653463
sage: all(SmallPermutationGroup(n,k).id() == [n,k]
34663464
....: for n in [1..64] for k in [1..numgps(n)])
@@ -3469,11 +3467,11 @@ class SmallPermutationGroup(PermutationGroup_generic):
34693467
sage: H.is_abelian()
34703468
False
34713469
sage: [H.centralizer(g) for g in H.conjugacy_classes_representatives()]
3472-
[Subgroup generated by [(1,2)(3,6)(4,5), (1,3,5)(2,4,6)] of
3470+
[Subgroup generated by [(1,3), (2,3)] of
34733471
(Group of order 6 and GAP Id 1 as a permutation group),
3474-
Subgroup generated by [(1,2)(3,6)(4,5)] of
3472+
Subgroup generated by [(2,3)] of
34753473
(Group of order 6 and GAP Id 1 as a permutation group),
3476-
Subgroup generated by [(1,3,5)(2,4,6), (1,5,3)(2,6,4)] of
3474+
Subgroup generated by [(1,2,3)] of
34773475
(Group of order 6 and GAP Id 1 as a permutation group)]
34783476
"""
34793477

0 commit comments

Comments
 (0)