Skip to content

Commit 721b952

Browse files
committed
Addressing reviewer comments.
1 parent 44b42b8 commit 721b952

File tree

3 files changed

+22
-4
lines changed

3 files changed

+22
-4
lines changed

src/sage/combinat/partition.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5538,8 +5538,8 @@ def simple_module_dimension(self, base_ring=None):
55385538
r"""
55395539
Return the dimension of the simple module corresponding to ``self``.
55405540
5541-
This is equal to the dimension of the Specht module over a field
5542-
of characteristic `0`.
5541+
When the base ring is a field of characteristic `0`, this is equal
5542+
to the dimension of the Specht module.
55435543
55445544
INPUT:
55455545

src/sage/combinat/specht_module.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ def polytabloid(T):
475475
476476
OUTPUT:
477477
478-
A ``dict`` whose keys are taboids represented by tuples of frozensets
478+
A ``dict`` whose keys are tabloids represented by tuples of frozensets
479479
and whose values are the coefficient.
480480
481481
EXAMPLES::
@@ -505,7 +505,7 @@ def tabloid_gram_matrix(la, base_ring):
505505
pulled back from the tabloid module.
506506
507507
For the module spanned by all tabloids, we define an bilinear form
508-
by having the taboids be an orthonormal basis. We then pull this
508+
by having the tabloids be an orthonormal basis. We then pull this
509509
bilinear form back across the natural injection of the Specht module
510510
into the tabloid module.
511511
@@ -541,6 +541,20 @@ def simple_module_rank(la, base_ring):
541541
sage: from sage.combinat.specht_module import simple_module_rank
542542
sage: simple_module_rank([3,2,1,1], GF(3))
543543
13
544+
545+
TESTS::
546+
547+
sage: from sage.combinat.specht_module import simple_module_rank
548+
sage: simple_module_rank([1,1,1,1], GF(3))
549+
Traceback (most recent call last):
550+
...
551+
ValueError: the partition [1, 1, 1, 1] is not 3-regular
552+
553+
sage: from sage.combinat.specht_module import simple_module_rank
554+
sage: simple_module_rank([2,1], GF(3)['x'])
555+
Traceback (most recent call last):
556+
...
557+
NotImplementedError: the base must be a field
544558
"""
545559
from sage.categories.fields import Fields
546560
from sage.combinat.partition import Partition

src/sage/combinat/symmetric_group_algebra.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1597,6 +1597,10 @@ def simple_module_dimension(self, la):
15971597
sage: SGA = SymmetricGroupAlgebra(GF(5), 6)
15981598
sage: SGA.simple_module_dimension(Partition([4,1,1]))
15991599
10
1600+
1601+
TESTS::
1602+
1603+
sage: SGA = SymmetricGroupAlgebra(GF(5), 6)
16001604
sage: SGA.simple_module_dimension(Partition([3,1,1]))
16011605
Traceback (most recent call last):
16021606
...

0 commit comments

Comments
 (0)