Skip to content

Conversation

@Myriad-Dreamin
Copy link
Contributor

Make sure these boxes are checked! πŸ“¦βœ…

  • You have the latest version of rustfmt installed
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ πŸ˜„ Thanks so much for contributing to wasm-pack! πŸ˜„ ✨✨

fix #1315.

I have tested it on my windows11 x86 pc, but not tested on macOS machines since I don't have one.

New endpoint changes target mac64 to mac-x64

    let target = if target::LINUX && target::x86_64 {
        "linux64"
    } else if target::MACOS && target::x86_64 {
        "mac-x64" // here!
    } else if target::MACOS && target::aarch64 {
        "mac-arm64"
    }

And that new endpoint provides chromedriver for mac-arm64:

    let target = if target::LINUX && target::x86_64 {
        "linux64"
    } else if target::MACOS && target::x86_64 {
        "mac-x64"
    } else if target::MACOS && target::aarch64 {
        "mac-arm64" // here!
    }

Copy link
Owner

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@drager drager merged commit 8cba32f into drager:master Nov 17, 2023
@tamird
Copy link

tamird commented Dec 19, 2023

Would it be possible to cut a new release with this?

@drager
Copy link
Owner

drager commented Jul 1, 2024

Would it be possible to cut a new release with this?

Released in v0.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chromedriver download using outdated endpoints.

3 participants