rustc: Inline bitwise modification operators

alexcrichton · alexcrichton · commit dd371a2069e8 · 2017-07-31T18:39:25.000-07:00
These need to be inlined across crates to avoid showing up as one-instruction functions in profiles! In the benchmark from #43578 this decreased the translation item collection step from 30s to 23s, and looks like it also allowed vectorization elsewhere of the operations!
diff --git a/src/librustc_data_structures/bitslice.rs b/src/librustc_data_structures/bitslice.rs
@@ -134,9 +134,11 @@ pub trait BitwiseOperator {
 
 pub struct Union;
 impl BitwiseOperator for Union {
+    #[inline]
     fn join(&self, a: usize, b: usize) -> usize { a | b }
 }
 pub struct Subtract;
 impl BitwiseOperator for Subtract {
+    #[inline]
     fn join(&self, a: usize, b: usize) -> usize { a & !b }
 }

Original file line number	Diff line number	Diff line change
`@@ -134,9 +134,11 @@ pub trait BitwiseOperator {`
`134`	`134`
`135`	`135`	`pub struct Union;`
`136`	`136`	`impl BitwiseOperator for Union {`
	`137`	`+ #[inline]`
`137`	`138`	`fn join(&self, a: usize, b: usize) -> usize { a \| b }`
`138`	`139`	`}`
`139`	`140`	`pub struct Subtract;`
`140`	`141`	`impl BitwiseOperator for Subtract {`
	`142`	`+ #[inline]`
`141`	`143`	`fn join(&self, a: usize, b: usize) -> usize { a & !b }`
`142`	`144`	`}`