crate/settings: Implement visibility logic for trustpub_only checkbox

The checkbox is now only visible when:
- There are GitHub or GitLab trustpub configs, OR
- The `trustpub_only` flag is currently enabled

When the user disables the checkbox with no configs present, the checkbox
stays visible for the duration of that page visit. On the next visit, it
will be hidden.

Author: Turbo87

app/controllers/crate/settings/index.js

@@ -13,6 +13,18 @@ export default class CrateSettingsController extends Controller {
   username = '';
   @tracked addOwnerVisible = false;
 
+  /**
+   * Tracks whether the trustpub_only checkbox was visible when the page loaded.
+   * This prevents the checkbox from disappearing immediately when unchecked
+   * if there are no configs - it will only disappear on the next page visit.
+   */
+  trustpubOnlyCheckboxWasVisible = false;
+
+  get showTrustpubOnlyCheckbox() {
+    let hasConfigs = this.githubConfigs?.length > 0 || this.gitlabConfigs?.length > 0;
+    return hasConfigs || this.crate?.trustpub_only || this.trustpubOnlyCheckboxWasVisible;
+  }
+
   @action showAddOwnerForm() {
     this.addOwnerVisible = true;
     this.username = '';

app/routes/crate/settings/index.js

@@ -19,5 +19,9 @@ export default class SettingsIndexRoute extends Route {
     controller.set('crate', crate);
     controller.set('githubConfigs', githubConfigs);
     controller.set('gitlabConfigs', gitlabConfigs);
+
+    // Capture whether the trustpub_only checkbox should be visible on initial load
+    let hasConfigs = githubConfigs?.length > 0 || gitlabConfigs?.length > 0;
+    controller.set('trustpubOnlyCheckboxWasVisible', hasConfigs || crate.trustpub_only);
   }
 }

app/templates/crate/settings/index.gjs

@@ -226,7 +226,9 @@ import UserAvatar from 'crates-io/components/user-avatar';
       </tbody>
     </table>
 
-    <TrustpubOnlyCheckbox @crate={{@controller.crate}} class='trustpub-only-checkbox' />
+    {{#if @controller.showTrustpubOnlyCheckbox}}
+      <TrustpubOnlyCheckbox @crate={{@controller.crate}} class='trustpub-only-checkbox' />
+    {{/if}}
   </div>
 
   <h2 class='header'>Danger Zone</h2>

tests/routes/crate/settings-test.js

@@ -278,10 +278,94 @@ module('Route | crate.settings', hooks => {
   });
 
   module('trustpub_only checkbox', function () {
+    test('hidden when no configs and flag is false', async function (assert) {
+      const { crate, user } = prepare(this);
+      this.authenticateAs(user);
+
+      await visit(`/crates/${crate.name}/settings`);
+
+      assert.dom('[data-test-trustpub-only-checkbox]').doesNotExist();
+    });
+
+    test('visible when GitHub configs exist', async function (assert) {
+      const { crate, user } = prepare(this);
+      this.authenticateAs(user);
+
+      this.db.trustpubGithubConfig.create({
+        crate,
+        repository_owner: 'rust-lang',
+        repository_name: 'crates.io',
+        workflow_filename: 'ci.yml',
+      });
+
+      await visit(`/crates/${crate.name}/settings`);
+
+      assert.dom('[data-test-trustpub-only-checkbox]').exists();
+      assert.dom('[data-test-trustpub-only-checkbox] [data-test-checkbox]').isNotChecked();
+    });
+
+    test('visible when GitLab configs exist', async function (assert) {
+      const { crate, user } = prepare(this);
+      this.authenticateAs(user);
+
+      this.db.trustpubGitlabConfig.create({
+        crate,
+        namespace: 'rust-lang',
+        project: 'crates.io',
+        workflow_filepath: '.gitlab-ci.yml',
+      });
+
+      await visit(`/crates/${crate.name}/settings`);
+
+      assert.dom('[data-test-trustpub-only-checkbox]').exists();
+      assert.dom('[data-test-trustpub-only-checkbox] [data-test-checkbox]').isNotChecked();
+    });
+
+    test('visible when flag is true but no configs', async function (assert) {
+      const { crate, user } = prepare(this);
+      this.db.crate.update({ where: { id: { equals: crate.id } }, data: { trustpubOnly: true } });
+      this.authenticateAs(user);
+
+      await visit(`/crates/${crate.name}/settings`);
+
+      assert.dom('[data-test-trustpub-only-checkbox]').exists();
+      assert.dom('[data-test-trustpub-only-checkbox] [data-test-checkbox]').isChecked();
+    });
+
+    test('stays visible after disabling when no configs exist', async function (assert) {
+      const { crate, user } = prepare(this);
+      this.db.crate.update({ where: { id: { equals: crate.id } }, data: { trustpubOnly: true } });
+      this.authenticateAs(user);
+
+      await visit(`/crates/${crate.name}/settings`);
+
+      assert.dom('[data-test-trustpub-only-checkbox]').exists();
+      assert.dom('[data-test-trustpub-only-checkbox] [data-test-checkbox]').isChecked();
+
+      await click('[data-test-trustpub-only-checkbox] [data-test-checkbox]');
+
+      // Checkbox stays visible after disabling (within same page visit)
+      assert.dom('[data-test-trustpub-only-checkbox]').exists();
+      assert.dom('[data-test-trustpub-only-checkbox] [data-test-checkbox]').isNotChecked();
+
+      // After navigating away and back, checkbox should be hidden
+      await visit(`/crates/${crate.name}`);
+      await visit(`/crates/${crate.name}/settings`);
+
+      assert.dom('[data-test-trustpub-only-checkbox]').doesNotExist();
+    });
+
     test('enabling trustpub_only', async function (assert) {
       const { crate, user } = prepare(this);
       this.authenticateAs(user);
 
+      this.db.trustpubGithubConfig.create({
+        crate,
+        repository_owner: 'rust-lang',
+        repository_name: 'crates.io',
+        workflow_filename: 'ci.yml',
+      });
+
       await visit(`/crates/${crate.name}/settings`);
 
       assert.dom('[data-test-trustpub-only-checkbox] [data-test-checkbox]').isNotChecked();
@@ -298,6 +382,13 @@ module('Route | crate.settings', hooks => {
       this.db.crate.update({ where: { id: { equals: crate.id } }, data: { trustpubOnly: true } });
       this.authenticateAs(user);
 
+      this.db.trustpubGithubConfig.create({
+        crate,
+        repository_owner: 'rust-lang',
+        repository_name: 'crates.io',
+        workflow_filename: 'ci.yml',
+      });
+
       await visit(`/crates/${crate.name}/settings`);
 
       assert.dom('[data-test-trustpub-only-checkbox] [data-test-checkbox]').isChecked();
@@ -313,6 +404,13 @@ module('Route | crate.settings', hooks => {
       const { crate, user } = prepare(this);
       this.authenticateAs(user);
 
+      this.db.trustpubGithubConfig.create({
+        crate,
+        repository_owner: 'rust-lang',
+        repository_name: 'crates.io',
+        workflow_filename: 'ci.yml',
+      });
+
       let deferred = defer();
       this.worker.use(http.patch('/api/v1/crates/:name', () => deferred.promise));