Limit the actionable error to install https inputs

Since I opened the PR, cargo started supporting `crate@version`
command-line inputs
2806270

and now the test input `git@bitbucket.org:jcmoyer/rust-tictactoe.git` is
parsed as a version string, which fails

the code path I added only deals with strings that weren't erroneously
parsed as version strings, so the section I highlighted above won't be
traversed, because `git@` strings now fail to parse as version strings
before they get here.

Delete the failing test

Author: petr-tik

src/cargo/ops/common_for_install_and_uninstall.rs

@@ -541,22 +541,8 @@ fn was_git_url_miscategorised_as_a_registry_dep(dep: &Dependency) -> InstallSugg
     if dep.source_id().is_registry() {
         if let Ok(git_url) = parse(BStr::new(dep.package_name().as_bytes())) {
             let final_git_url: Option<InternedString> = match git_url.scheme {
-                // cargo doesn't support cargo install git@ urls, so
-                Scheme::Ssh | Scheme::Git => {
-                    if let (Some(host), Some(owner)) = (git_url.host(), git_url.user()) {
-                        let https_git_url = format!(
-                            "https://{host}/{owner}/{repo_name}",
-                            // repo_name = git_url.name()
-                            repo_name = "TODO"
-                        );
-                        Some(InternedString::from(https_git_url))
-                    } else {
-                        None
-                    }
-                }
                 Scheme::Http | Scheme::Https => Some(dep.package_name()),
-                // otherwise cargo install bar will interpret bar as a file-based
-                // git repo
+                // cargo doesn't support cargo install git@ urls
                 _ => None,
             };
 

tests/testsuite/install.rs

@@ -1655,19 +1655,6 @@ error: could not find `https://github.com/rust-lang/cargo` in registry `crates-i
         .run();
 }
 
-#[cargo_test]
-fn test_install_from_git_generate_suggestion() {
-    registry::init();
-    cargo_process("install git@bitbucket.org:jcmoyer/rust-tictactoe.git")
-        .with_status(101)
-        .with_stderr(
-            "\
-[UPDATING] `[..]` index
-error: could not find `git@bitbucket.org:jcmoyer/rust-tictactoe.git` in registry `crates-io` with version `*`. To install a package from a git repository, use `--git https://bitbucket.org/jcmoyer/rust-tictactoe`",
-        )
-        .run();
-}
-
 #[cargo_test]
 fn uninstall_multiple_and_specifying_bin() {
     cargo_process("uninstall foo bar --bin baz")